This is an archive of the discontinued LLVM Phabricator instance.

Differential D121205

[MLIR][Presburger] Silence warnings in GCC (NFC)
ClosedPublic

Authored by chelini on Mar 8 2022, 3:19 AM.

Details

Reviewers
arjunp
Commits
rGf3e1dcc5df88: [MLIR][Presburger] Silence warnings in GCC (NFC)

Diff Detail

Event Timeline

chelini created this revision.Mar 8 2022, 3:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 3:19 AM
Herald added subscribers: arjunp, sdasgup3, Groverkss and 21 others. · View Herald Transcript
chelini requested review of this revision.Mar 8 2022, 3:19 AM
Herald added a project: Restricted Project. · View Herald TranscriptMar 8 2022, 3:19 AM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
chelini added a reviewer: arjunp.Mar 8 2022, 3:20 AM
arjunp accepted this revision.Mar 8 2022, 3:25 AM

Thanks. Can you mention in the description that the warnings occur in g++?

This revision is now accepted and ready to land.Mar 8 2022, 3:25 AM
Harbormaster completed remote builds in B153117: Diff 413753.Mar 8 2022, 3:35 AM
chelini updated this revision to Diff 413754.Mar 8 2022, 3:37 AM

Address comment

chelini retitled this revision from [MLIR][Presburger] Silence warnings (NFC) to [MLIR][Presburger] Silence warnings in GCC (NFC).Mar 8 2022, 3:37 AM
This revision was landed with ongoing or failed builds.Mar 8 2022, 3:39 AM
Closed by commit rGf3e1dcc5df88: [MLIR][Presburger] Silence warnings in GCC (NFC) (authored by chelini). · Explain Why
This revision was automatically updated to reflect the committed changes.
chelini added a commit: rGf3e1dcc5df88: [MLIR][Presburger] Silence warnings in GCC (NFC).
Harbormaster completed remote builds in B153118: Diff 413754.Mar 8 2022, 3:53 AM

Revision Contents

PathSize
mlir/
unittests/
Analysis/
Presburger/
6 lines

Diff 413755

mlir/unittests/Analysis/Presburger/IntegerPolyhedronTest.cpp

Show First 20 Lines • Show All 75 Lines • ▼ Show 20 Lines if (!hasSample) {
llvm::errs() << "getIntegerLexMin gave sample: "; llvm::errs() << "getIntegerLexMin gave sample: ";
dump(*maybeLexMin); dump(*maybeLexMin);
} }
} else { } else {
ASSERT_TRUE(maybeSample.hasValue()); ASSERT_TRUE(maybeSample.hasValue());
EXPECT_TRUE(poly.containsPoint(*maybeSample)); EXPECT_TRUE(poly.containsPoint(*maybeSample));
ASSERT_FALSE(maybeLexMin.isEmpty()); ASSERT_FALSE(maybeLexMin.isEmpty());
if (maybeLexMin.isUnbounded()) if (maybeLexMin.isUnbounded()) {
EXPECT_TRUE(Simplex(poly).isUnbounded()); EXPECT_TRUE(Simplex(poly).isUnbounded());
if (maybeLexMin.isBounded()) }
if (maybeLexMin.isBounded()) {
EXPECT_TRUE(poly.containsPoint(*maybeLexMin)); EXPECT_TRUE(poly.containsPoint(*maybeLexMin));
} }
}
break; break;
case TestFunction::Empty: case TestFunction::Empty:
EXPECT_EQ(!hasSample, poly.isIntegerEmpty()); EXPECT_EQ(!hasSample, poly.isIntegerEmpty());
break; break;
} }
} }
/// Check sampling for all the permutations of the dimensions for the given /// Check sampling for all the permutations of the dimensions for the given
▲ Show 20 Lines • Show All 1,092 Lines • Show Last 20 Lines