The concept is based on P2286R2 Formatting Ranges. It will be used to
optimise the storage of __format_arg_store as required by LWG-3473.
Depends on D120916
Paths
| Differential D120921
[libc++][format] Adds a formattable concept. ClosedPublic Authored by Mordante on Mar 3 2022, 10:28 AM.
Details
Summary The concept is based on P2286R2 Formatting Ranges. It will be used to Depends on D120916
Diff Detail
Event Timeline• Quuxplusone added inline comments.
Mordante added a child revision: D121138: [libc++][format] Adds formatter<charT[N], charT>..Mar 7 2022, 10:20 AM Comment Actions Please ping me on Discord if I should be reviewing this -- my understanding is that it's for a not-yet-approved paper? (if so, you can mark this as "changes planned" until you'd like a review)
Comment Actions
Correct the paper isn't accepted yet and the paper targets C++23. However as mentioned in the description I need a formattable concept in C++20. I use the concept in D121514. So I either:
Using an existing proposal allows me to reuse this "private" concept in C++23 avoiding code duplication.
Comment Actions Thanks for the review!
This revision is now accepted and ready to land.May 18 2022, 10:58 AM Closed by commit rG15c809e8e780: [libc++][format] Adds a formattable concept. (authored by Mordante). · Explain WhyMay 18 2022, 11:02 AM This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 412762 libcxx/include/CMakeLists.txt
libcxx/include/__format/concepts.h
libcxx/include/__format/format_context.h
libcxx/include/__format/format_fwd.h
libcxx/include/format
libcxx/include/module.modulemap
libcxx/test/libcxx/diagnostics/detail.headers/format/concepts.module.verify.cpp
libcxx/test/libcxx/utilities/format/format.formatter/format.formatter.spec/formattable.compile.pass.cpp
|
clang-format suggested style edits found: