This is an archive of the discontinued LLVM Phabricator instance.

Differential D120629

[clang] Remove unused variable AllElementsInt. NFC.
ClosedPublic

Authored by • Quuxplusone on Feb 27 2022, 7:49 AM.

Details

Reviewers
rnk
rsmith
sammccall
Commits
rGd3db74eadbfc: [clang] Remove unused variable AllElementsInt.
Summary

This has been unused ever since it was committed in b8a501ccf1.

Diff Detail

Event Timeline

• Quuxplusone requested review of this revision.Feb 27 2022, 7:49 AM
• Quuxplusone created this revision.
Herald added a subscriber: cfe-commits. · View Herald TranscriptFeb 27 2022, 7:49 AM
Harbormaster completed remote builds in B151663: Diff 411677.Feb 27 2022, 8:19 AM
rnk accepted this revision.Feb 28 2022, 9:24 AM

lgtm

This revision is now accepted and ready to land.Feb 28 2022, 9:24 AM
This revision was landed with ongoing or failed builds.Feb 28 2022, 9:28 AM
Closed by commit rGd3db74eadbfc: [clang] Remove unused variable AllElementsInt. (authored by • arthur.j.odwyer). · Explain Why
This revision was automatically updated to reflect the committed changes.
• arthur.j.odwyer added a commit: rGd3db74eadbfc: [clang] Remove unused variable AllElementsInt..

Revision Contents

PathSize
clang/
lib/
Sema/
7 lines

Diff 411677

clang/lib/Sema/SemaDecl.cpp

Show First 20 Lines • Show All 991 Lines • ▼ Show 20 Lines
unsigned CharWidth = Context.getTargetInfo().getCharWidth(); unsigned CharWidth = Context.getTargetInfo().getCharWidth();
unsigned ShortWidth = Context.getTargetInfo().getShortWidth(); unsigned ShortWidth = Context.getTargetInfo().getShortWidth();
// Verify that all the values are okay, compute the size of the values, and // Verify that all the values are okay, compute the size of the values, and
// reverse the list. // reverse the list.
unsigned NumNegativeBits = 0; unsigned NumNegativeBits = 0;
unsigned NumPositiveBits = 0; unsigned NumPositiveBits = 0;
// Keep track of whether all elements have type int.
bool AllElementsInt = true;
for (unsigned i = 0, e = Elements.size(); i != e; ++i) { for (unsigned i = 0, e = Elements.size(); i != e; ++i) {
EnumConstantDecl *ECD = EnumConstantDecl *ECD =
cast_or_null<EnumConstantDecl>(Elements[i]); cast_or_null<EnumConstantDecl>(Elements[i]);
if (!ECD) continue; // Already issued a diagnostic. if (!ECD) continue; // Already issued a diagnostic.
const llvm::APSInt &InitVal = ECD->getInitVal(); const llvm::APSInt &InitVal = ECD->getInitVal();
// Keep track of the size of positive and negative values. // Keep track of the size of positive and negative values.
if (InitVal.isUnsigned() || InitVal.isNonNegative()) if (InitVal.isUnsigned() || InitVal.isNonNegative())
NumPositiveBits = std::max(NumPositiveBits, NumPositiveBits = std::max(NumPositiveBits,
(unsigned)InitVal.getActiveBits()); (unsigned)InitVal.getActiveBits());
else else
NumNegativeBits = std::max(NumNegativeBits, NumNegativeBits = std::max(NumNegativeBits,
Lint: Pre-merge checks
Inline Actions

clang-format: please reformat the code

-      NumNegativeBits = std::max(NumNegativeBits,
-                                 (unsigned)InitVal.getMinSignedBits());
+      NumNegativeBits =
+          std::max(NumNegativeBits, (unsigned)InitVal.getMinSignedBits());
Lint: Pre-merge checks: clang-format: please reformat the code ``` - NumNegativeBits = std::max(NumNegativeBits…
(unsigned)InitVal.getMinSignedBits()); (unsigned)InitVal.getMinSignedBits());
// Keep track of whether every enum element has type int (very common).
if (AllElementsInt)
AllElementsInt = ECD->getType() == Context.IntTy;
} }
// Figure out the type that should be used for this enum. // Figure out the type that should be used for this enum.
QualType BestType; QualType BestType;
unsigned BestWidth; unsigned BestWidth;
// C++0x N3000 [conv.prom]p3: // C++0x N3000 [conv.prom]p3:
// An rvalue of an unscoped enumeration type whose underlying // An rvalue of an unscoped enumeration type whose underlying
▲ Show 20 Lines • Show All 339 Lines • Show Last 20 Lines