This is an archive of the discontinued LLVM Phabricator instance.

Differential D120493

[NVPTX][AsmPrinter] Emit .attribute(.managed) for global variable declarations
ClosedPublic

Authored by krisb on Feb 24 2022, 8:36 AM.

Details

Reviewers
tra
jholewinski
Commits
rG3fe6f9388fd3: [NVPTX][AsmPrinter] Emit .attribute(.managed) for global variable declarations
Summary

Declaration and definition attributes must match,
otherwise it may cause issues on linking.

Diff Detail

Event Timeline

krisb created this revision.Feb 24 2022, 8:36 AM
Herald added subscribers: asavonic, hiraditya. · View Herald TranscriptFeb 24 2022, 8:36 AM
krisb requested review of this revision.Feb 24 2022, 8:36 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 24 2022, 8:36 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B151289: Diff 411144.Feb 24 2022, 9:26 AM
tra accepted this revision.Feb 24 2022, 12:23 PM
This revision is now accepted and ready to land.Feb 24 2022, 12:23 PM
This revision was landed with ongoing or failed builds.Feb 25 2022, 12:22 AM
Closed by commit rG3fe6f9388fd3: [NVPTX][AsmPrinter] Emit .attribute(.managed) for global variable declarations (authored by krisb). · Explain Why
This revision was automatically updated to reflect the committed changes.
krisb added a commit: rG3fe6f9388fd3: [NVPTX][AsmPrinter] Emit .attribute(.managed) for global variable declarations.

Revision Contents

PathSize
llvm/
lib/
Target/
NVPTX/
2 lines
test/
CodeGen/
NVPTX/
7 lines

Diff 411144

llvm/lib/Target/NVPTX/NVPTXAsmPrinter.cpp

Show First 20 Lines • Show All 1,284 Lines • ▼ Show 20 Linesvoid NVPTXAsmPrinter::emitPTXGlobalVariable(const GlobalVariable *GVar,
raw_ostream &O) { raw_ostream &O) {
const DataLayout &DL = getDataLayout(); const DataLayout &DL = getDataLayout();
// GlobalVariables are always constant pointers themselves. // GlobalVariables are always constant pointers themselves.
Type *ETy = GVar->getValueType(); Type *ETy = GVar->getValueType();
O << "."; O << ".";
emitPTXAddressSpace(GVar->getType()->getAddressSpace(), O); emitPTXAddressSpace(GVar->getType()->getAddressSpace(), O);
if (isManaged(*GVar))
O << " .attribute(.managed)";
if (MaybeAlign A = GVar->getAlign()) if (MaybeAlign A = GVar->getAlign())
O << " .align " << A->value(); O << " .align " << A->value();
else else
O << " .align " << (int)DL.getPrefTypeAlignment(ETy); O << " .align " << (int)DL.getPrefTypeAlignment(ETy);
// Special case for i128 // Special case for i128
if (ETy->isIntegerTy(128)) { if (ETy->isIntegerTy(128)) {
O << " .b8 "; O << " .b8 ";
▲ Show 20 Lines • Show All 823 Lines • Show Last 20 Lines

llvm/test/CodeGen/NVPTX/managed.ll

; RUN: llc < %s -march=nvptx -mcpu=sm_20 | FileCheck %s ; RUN: llc < %s -march=nvptx -mcpu=sm_20 | FileCheck %s
; CHECK: .visible .global .align 4 .u32 device_g; ; CHECK: .visible .global .align 4 .u32 device_g;
@device_g = addrspace(1) global i32 zeroinitializer @device_g = addrspace(1) global i32 zeroinitializer
; CHECK: .visible .global .attribute(.managed) .align 4 .u32 managed_g; ; CHECK: .visible .global .attribute(.managed) .align 4 .u32 managed_g;
@managed_g = addrspace(1) global i32 zeroinitializer @managed_g = addrspace(1) global i32 zeroinitializer
; CHECK: .extern .global .align 4 .u32 decl_g;
@decl_g = external addrspace(1) global i32, align 4
; CHECK: .extern .global .attribute(.managed) .align 8 .b32 managed_decl_g;
@managed_decl_g = external addrspace(1) global i32*, align 8
!nvvm.annotations = !{!0} !nvvm.annotations = !{!0, !1}
!0 = !{i32 addrspace(1)* @managed_g, !"managed", i32 1} !0 = !{i32 addrspace(1)* @managed_g, !"managed", i32 1}
!1 = !{i32* addrspace(1)* @managed_decl_g, !"managed", i32 1}