Page MenuHomePhabricator

WindowsARM: ignore calling conventions as described on MSDN
ClosedPublic

Authored by martell on Aug 14 2015, 9:17 AM.

Details

Summary

MSDN says that fastcall stdcall and thiscall and vectorcall are all accepted but ignored on ARM and X64

https://msdn.microsoft.com/en-us/library/984x0h58.aspx

MSDN also says that cdecl is accepted but typically ignored

This patch brings ARM in line with how we ignore them for X64

Diff Detail

Repository
rL LLVM

Event Timeline

martell updated this revision to Diff 32158.Aug 14 2015, 9:17 AM
martell retitled this revision from to WindowsARM: ignore calling conventions as described on MSDN.
martell updated this object.
martell added a reviewer: rnk.
martell added subscribers: compnerd, cfe-commits.
rnk added inline comments.Aug 14 2015, 9:25 AM
test/Parser/arm-windows-calling-convention-handling.c
2 ↗(On Diff #32158)

Keep this test, add a line like this:

// expected-no-diagnostics

And remove the rest of the diagnostic expectations.

martell added inline comments.Aug 14 2015, 9:56 AM
test/Parser/arm-windows-calling-convention-handling.c
2 ↗(On Diff #32158)

Sure I can do that :)

Will I add the same test for x64 as I don't see any?

rnk added inline comments.Aug 14 2015, 10:13 AM
test/Parser/arm-windows-calling-convention-handling.c
2 ↗(On Diff #32158)

Sure, copy-paste the RUN line and replace thumb7 with x86_64.

martell updated this revision to Diff 32164.Aug 14 2015, 10:45 AM

updated to reflect rnk comments

This revision was automatically updated to reflect the committed changes.