Adds a flag to optionally disable tosa decompositions

[mehdi_amini]

mlir/include/mlir/Conversion/TosaToLinalg/TosaToLinalg.h

28

Please document the flag above. Not so much what it does (don't just repeat the name in a sentence) but why would someone use it, etc.

mlir/lib/Conversion/TosaToLinalg/TosaToLinalgPass.cpp

75

Nit: drop the braces

[not-jenni]

Adds a flag to optionally disable tosa decompositions

mlir/include/mlir/Conversion/TosaToLinalg/TosaToLinalg.h

 namespace mlir {
 namespace tosa {
 
 std::unique_ptr<Pass> createTosaToLinalg();
 std::unique_ptr<Pass> createTosaToLinalgNamed();
 
 /// Populates passes to convert from TOSA to Linalg on buffers. At the end of
 /// the pass, the function will only contain linalg ops or standard ops if the
-/// pipeline succeeds.
-void addTosaToLinalgPasses(OpPassManager &pm);
+/// pipeline succeeds.  The option to disable decompositions is available for
+/// benchmarking performance improvements from the canonicalizations.
+void addTosaToLinalgPasses(OpPassManager &pm,
+                           bool disableTosaDecompositions = false);
 
 /// Populates conversion passes from TOSA dialect to Linalg dialect.
 void populateTosaToLinalgConversionPatterns(RewritePatternSet *patterns);
 
 /// Populates conversion passes from TOSA dialect to Linalg named operations.
 void populateTosaToLinalgNamedConversionPatterns(RewritePatternSet *patterns);
 
 } // namespace tosa
 } // namespace mlir
 
 #endif // MLIR_CONVERSION_TOSATOLINALG_TOSATOLINALG_H

mlir/lib/Conversion/TosaToLinalg/TosaToLinalgPass.cpp

public:
   }
 };
 } // namespace
 
 std::unique_ptr<Pass> mlir::tosa::createTosaToLinalg() {
   return std::make_unique<TosaToLinalg>();
 }
 
-void mlir::tosa::addTosaToLinalgPasses(OpPassManager &pm) {
+void mlir::tosa::addTosaToLinalgPasses(OpPassManager &pm,
+                                       bool disableTosaDecompositions) {
   // Optional decompositions are designed to benefit linalg.
+  if (!disableTosaDecompositions)
     pm.addNestedPass<FuncOp>(mlir::tosa::createTosaOptionalDecompositions());
   pm.addNestedPass<FuncOp>(mlir::createCanonicalizerPass());
 
   pm.addNestedPass<FuncOp>(tosa::createTosaMakeBroadcastablePass());
   pm.addNestedPass<FuncOp>(tosa::createTosaToLinalgNamed());
   pm.addNestedPass<FuncOp>(mlir::createCanonicalizerPass());
   pm.addNestedPass<FuncOp>(tosa::createTosaMakeBroadcastablePass());
   pm.addNestedPass<FuncOp>(tosa::createTosaToLinalg());
 }