This is an archive of the discontinued LLVM Phabricator instance.

[CodeGen] Return better Changed status from PostRAHazardRecognizer
ClosedPublic

Authored by foad on Feb 16 2022, 9:08 AM.

Diff Detail

Event Timeline

foad created this revision.Feb 16 2022, 9:08 AM
foad requested review of this revision.Feb 16 2022, 9:08 AM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 16 2022, 9:08 AM
piotr added inline comments.Feb 16 2022, 12:04 PM
llvm/lib/CodeGen/PostRAHazardRecognizer.cpp
98

You can check NumNoops here instead?

myhsu added inline comments.Feb 16 2022, 1:01 PM
llvm/lib/CodeGen/PostRAHazardRecognizer.cpp
89

nit

98

I don't think so, NumNoops is a global variable that accumulates its value through the program's lifetime

piotr added inline comments.Feb 17 2022, 12:51 AM
llvm/lib/CodeGen/PostRAHazardRecognizer.cpp
98

I don't think so, NumNoops is a global variable that accumulates its value through the program's lifetime

Ah, of course.

foad updated this revision to Diff 409539.Feb 17 2022, 1:35 AM

Fix nit.

myhsu accepted this revision.Feb 17 2022, 10:00 AM

LGTM

This revision is now accepted and ready to land.Feb 17 2022, 10:00 AM