Page MenuHomePhabricator

Revert "[SystemZ][z/OS] Fix f32 variadic argument assertion"
ClosedPublic

Authored by mubarizafzal on Feb 15 2022, 5:36 PM.

Details

Summary

This patch reverts the f32 vararg fix (https://reviews.llvm.org/D119868) which had a test case that failed on different buildbots (ex. Link)

Diff Detail

Unit TestsFailed

TimeTest
50 msx64 debian > Clang.Misc::warning-flags.c
Script: -- : 'RUN: at line 1'; diagtool list-warnings > /var/lib/buildkite-agent/builds/llvm-project/build/tools/clang/test/Misc/Output/warning-flags.c.tmp 2>&1

Event Timeline

mubarizafzal created this revision.Feb 15 2022, 5:36 PM
mubarizafzal requested review of this revision.Feb 15 2022, 5:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 15 2022, 5:36 PM
thakis accepted this revision.Feb 15 2022, 7:32 PM
thakis added a subscriber: thakis.

No need to have reverts reviewed. If you land something and it breaks tests, just land the revert. That's better than keeping the tree red.

(lg – please land this quickly :) )

This revision is now accepted and ready to land.Feb 15 2022, 7:32 PM
thakis closed this revision.Feb 16 2022, 6:10 AM

this landed in 1a5b881d4cf0

No need to have reverts reviewed. If you land something and it breaks tests, just land the revert. That's better than keeping the tree red.

(lg – please land this quickly :) )

Ah makes sense. Thanks for the help !