Differential D119879

[DSE] Model reads after returning explicitly in MemSSA.
Needs ReviewPublic
Actions

Authored by fhahn on Feb 15 2022, 12:04 PM.

Details

Reviewers: None

Summary

This allows removing the post-dominance/CFG checks, after the full read
check.

This catches a tiny amount of additional cases, because we are not
restricted to the CFG traversal limit.

For MultiSource/SPEC2006/SPEC2017 on X86 with -O3:

Program base patch diff
test-suite...Source/Benchmarks/sim/sim.test 4.00 6.00 50.0%
test-suite...epsjeng_r/531.deepsjeng_r.test 44.00 48.00 9.1%
test-suite...T2006/445.gobmk/445.gobmk.test 46.00 47.00 2.2%
test-suite...ate/525.x264_r/525.x264_r.test 400.00 402.00 0.5%
test-suite...7rate/502.gcc_r/502.gcc_r.test 1241.00 1246.00 0.4%
test-suite...-typeset/consumer-typeset.test 766.00 767.00 0.1%
test-suite...6.blender_r/526.blender_r.test 3743.00 3745.00 0.1%

Compile-time wise this is mostly neutral
https://llvm-compile-time-tracker.com/compare.php?from=dd145f953db3dafbc019f1d3783bb4f09a28af92&to=55c8c0b5ec1257c46b004e6247c327b8677dc6cc&stat=instructions

See D119760.

Diff Detail

Repository: rG LLVM Github Monorepo

Unit TestsFailed
View All

	Time	Test
	60,110 ms	x64 debian > Clang.CodeGen/RISCV/rvv-intrinsics::vloxseg.c Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/bin/clang -cc1 -internal-isystem /var/lib/buildkite-agent/builds/llvm-project/build/lib/clang/15.0.0/include -nostdsysteminc -triple riscv64 -target-feature +f -target-feature +d -target-feature +zfh -target-feature +v -disable-O0-optnone -emit-llvm /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg.c -o - \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/opt -S -mem2reg \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --check-prefix=CHECK-RV64 /var/lib/buildkite-agent/builds/llvm-project/clang/test/CodeGen/RISCV/rvv-intrinsics/vloxseg.c
	60,090 ms	x64 debian > MLIR.Examples/standalone::test.toy Script: -- : 'RUN: at line 1'; /usr/bin/cmake /var/lib/buildkite-agent/builds/llvm-project/mlir/examples/standalone -G "Ninja" -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_C_COMPILER=/usr/bin/clang -DLLVM_ENABLE_LIBCXX=OFF -DMLIR_DIR=/var/lib/buildkite-agent/builds/llvm-project/build/lib/cmake/mlir ; /usr/bin/cmake --build . --target check-standalone \| tee /var/lib/buildkite-agent/builds/llvm-project/build/tools/mlir/test/Examples/standalone/Output/test.toy.tmp \| /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck /var/lib/buildkite-agent/builds/llvm-project/mlir/test/Examples/standalone/test.toy
	60,050 ms	x64 debian > ThreadSanitizer-x86_64.ThreadSanitizer-x86_64::restore_stack.cpp Script: -- : 'RUN: at line 1'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -fsanitize=thread -Wall -m64 -msse4.2 -gline-tables-only -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -std=c++11 -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/../ -O1 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/restore_stack.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/restore_stack.cpp.tmp && not /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/tsan/X86_64Config/Output/restore_stack.cpp.tmp 2>&1 \| FileCheck /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/tsan/restore_stack.cpp
	60,070 ms	x64 debian > libFuzzer.libFuzzer::large.test Script: -- : 'RUN: at line 3'; /var/lib/buildkite-agent/builds/llvm-project/build/./bin/clang --driver-mode=g++ -O2 -gline-tables-only -fsanitize=address,fuzzer -I/var/lib/buildkite-agent/builds/llvm-project/compiler-rt/lib/fuzzer -m64 /var/lib/buildkite-agent/builds/llvm-project/compiler-rt/test/fuzzer/LargeTest.cpp -o /var/lib/buildkite-agent/builds/llvm-project/build/projects/compiler-rt/test/fuzzer/X86_64DefaultLinuxConfig/Output/large.test.tmp-LargeTest