This is an archive of the discontinued LLVM Phabricator instance.

[ProfData] Change type of options from int to uint64_t.
ClosedPublic

Authored by mingmingl on Feb 14 2022, 11:18 PM.

Details

Summary
  • Reader uses option values to override uint64_t values.

Diff Detail

Event Timeline

mingmingl created this revision.Feb 14 2022, 11:18 PM
mingmingl published this revision for review.Feb 14 2022, 11:20 PM
mingmingl added reviewers: snehasish, hoy, wenlei.

Adding reviewers based on history (https://github.com/llvm/llvm-project/commits/main/llvm/lib/ProfileData/ProfileSummaryBuilder.cpp) but let me know if I should modify reviewers. thanks!

Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 11:21 PM
snehasish accepted this revision.Feb 15 2022, 9:58 AM

lgtm, I looked at the uses and in each case it's immediately passed to getEntryForPercentile which accepts the int as uint64_t.

This revision is now accepted and ready to land.Feb 15 2022, 9:58 AM
hoy accepted this revision.Feb 15 2022, 10:00 AM

lgtm.

wenlei accepted this revision.Feb 15 2022, 10:01 AM
This revision was landed with ongoing or failed builds.Feb 15 2022, 10:59 AM
This revision was automatically updated to reflect the committed changes.