This is an archive of the discontinued LLVM Phabricator instance.

Differential D119741

[ifs] Add the invalid STRSZ test to llvm-ifs
ClosedPublic

Authored by haowei on Feb 14 2022, 10:49 AM.

Details

Reviewers
jhenderson
mcgrathr
phosek
Commits
rG1af309d0c2ef: [ifs] Add the invalid STRSZ test to llvm-ifs
Summary

This patch adds an addition test to test llvm-ifs's behavior when DT_STRSZ value from .dynamic is invalid

Diff Detail

Unit TestsFailed

TimeTest
60,030 msx64 debian > MLIR.Examples/standalone::test.toy
60,030 msx64 debian > libFuzzer.libFuzzer::large.test

Event Timeline

haowei requested review of this revision.Feb 14 2022, 10:49 AM
haowei created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 14 2022, 10:49 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
haowei mentioned this in D116769: [ifs] Allow llvm-ifs to generate text stub from elf stub.Feb 14 2022, 10:56 AM
Harbormaster completed remote builds in B149442: Diff 408506.Feb 14 2022, 11:47 AM
jhenderson added inline comments.Feb 14 2022, 11:53 PM
llvm/test/tools/llvm-ifs/binary-read-bad-vaddr.test
61

Rather than duplicating the YAML, you'd be better off using yaml2obj's -D option to parameterize the fields that vary between the two test cases. You can specify default values for fields using the variable defined by that option, so that you only need one -D per test case.

105

This is essentially identical to ERR1, but with a different value. Perhaps use FileCheck -D to parameterize the value, rather than duplicating the entire message?

haowei updated this revision to Diff 409004.Feb 15 2022, 12:20 PM
haowei added a comment.Feb 15 2022, 12:23 PM

I wasn't aware yaml2obj support -D as well. Thanks for pointing it out.

Harbormaster completed remote builds in B149794: Diff 409004.Feb 15 2022, 2:46 PM
jhenderson accepted this revision.Feb 16 2022, 12:25 AM

LGTM!

This revision is now accepted and ready to land.Feb 16 2022, 12:25 AM
This revision was landed with ongoing or failed builds.Feb 16 2022, 9:58 AM
Closed by commit rG1af309d0c2ef: [ifs] Add the invalid STRSZ test to llvm-ifs (authored by haowei). · Explain Why
This revision was automatically updated to reflect the committed changes.
haowei added a commit: rG1af309d0c2ef: [ifs] Add the invalid STRSZ test to llvm-ifs.

Revision Contents

PathSize
llvm/
test/
tools/
llvm-ifs/
18 lines

Diff 409004

llvm/test/tools/llvm-ifs/binary-read-bad-vaddr.test

# RUN: yaml2obj %s -o %t ## Check bad DT_STRTAB address.
# RUN: not llvm-ifs --input-format=ELF --output-ifs=%t.tbe %t 2>&1 | FileCheck %s
# RUN: yaml2obj %s -DSTRSZ_VALUE=0x0000000000000001 -DSTRTAB_ADDR=0x0000000000000260 -o %t
# RUN: not llvm-ifs --input-format=ELF --output-ifs=%t.tbe %t 2>&1 | FileCheck %s -DERR_ADDR=0x260
## Check bad DT_STRSZ size.
# RUN: yaml2obj %s -DSTRSZ_VALUE=0x0000000000001000 -DSTRTAB_ADDR=0x0000000000001000 -o %t
# RUN: not llvm-ifs --input-format=ELF --output-ifs=%t.tbe %t 2>&1 | FileCheck %s -DERR_ADDR=0x2000
!ELF !ELF
FileHeader: FileHeader:
Class: ELFCLASS64 Class: ELFCLASS64
Data: ELFDATA2LSB Data: ELFDATA2LSB
Type: ET_DYN Type: ET_DYN
Machine: EM_X86_64 Machine: EM_X86_64
Sections: Sections:
- Name: .dynstr - Name: .dynstr
Type: SHT_STRTAB Type: SHT_STRTAB
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Address: 0x1000 Address: 0x1000
Content: "00" Content: "00"
- Name: .dynamic - Name: .dynamic
Type: SHT_DYNAMIC Type: SHT_DYNAMIC
Flags: [ SHF_ALLOC ] Flags: [ SHF_ALLOC ]
Address: 0x0000000000001008 Address: 0x0000000000001008
Link: .dynstr Link: .dynstr
AddressAlign: 0x0000000000000008 AddressAlign: 0x0000000000000008
EntSize: 0x0000000000000010 EntSize: 0x0000000000000010
Entries: Entries:
- Tag: DT_SONAME - Tag: DT_SONAME
Value: 0x0000000000000000 Value: 0x0000000000000000
- Tag: DT_STRSZ - Tag: DT_STRSZ
Value: 0x0000000000000001 Value: [[STRSZ_VALUE]]
- Tag: DT_STRTAB - Tag: DT_STRTAB
Value: 0x0000000000000260 # Bad vaddr (no PT_LOAD for 0x0000 to 0x0FFF) Value: [[STRTAB_ADDR]]
- Tag: DT_SYMTAB - Tag: DT_SYMTAB
Value: 0x0000000000001000 Value: 0x0000000000001000
- Tag: DT_NULL - Tag: DT_NULL
Value: 0x0000000000000000 Value: 0x0000000000000000
ProgramHeaders: ProgramHeaders:
- Type: PT_LOAD - Type: PT_LOAD
Flags: [ PF_R ] Flags: [ PF_R ]
VAddr: 0x1000 VAddr: 0x1000
Align: 8 Align: 8
FirstSec: .dynstr FirstSec: .dynstr
LastSec: .dynamic LastSec: .dynamic
- Type: PT_DYNAMIC - Type: PT_DYNAMIC
Flags: [ PF_X, PF_R ] Flags: [ PF_X, PF_R ]
VAddr: 0x1008 VAddr: 0x1008
FirstSec: .dynamic FirstSec: .dynamic
LastSec: .dynamic LastSec: .dynamic
# CHECK: virtual address is not in any segment: 0x260 when locating dynamic string table section contents # CHECK: virtual address is not in any segment: [[ERR_ADDR]] when locating dynamic string table section contents
jhendersonUnsubmitted
Not Done
ReplyInline Actions

Rather than duplicating the YAML, you'd be better off using yaml2obj's -D option to parameterize the fields that vary between the two test cases. You can specify default values for fields using the variable defined by that option, so that you only need one -D per test case.

jhenderson: Rather than duplicating the YAML, you'd be better off using yaml2obj's -D option to…
jhendersonUnsubmitted
Not Done
ReplyInline Actions

This is essentially identical to ERR1, but with a different value. Perhaps use FileCheck -D to parameterize the value, rather than duplicating the entire message?

jhenderson: This is essentially identical to ERR1, but with a different value. Perhaps use FileCheck -D to…