[ifs] Add the invalid STRSZ test to llvm-ifs

[haowei]

Summary

This patch adds an addition test to test llvm-ifs's behavior when DT_STRSZ value from .dynamic is invalid

[jhenderson]

llvm/test/tools/llvm-ifs/binary-read-bad-vaddr.test

61

Rather than duplicating the YAML, you'd be better off using yaml2obj's -D option to parameterize the fields that vary between the two test cases. You can specify default values for fields using the variable defined by that option, so that you only need one -D per test case.

105

This is essentially identical to ERR1, but with a different value. Perhaps use FileCheck -D to parameterize the value, rather than duplicating the entire message?

[haowei]

I wasn't aware yaml2obj support -D as well. Thanks for pointing it out.

[jhenderson]

LGTM!

llvm/test/tools/llvm-ifs/binary-read-bad-vaddr.test

-# RUN: yaml2obj %s -o %t
-# RUN: not llvm-ifs --input-format=ELF --output-ifs=%t.tbe %t 2>&1 | FileCheck %s
+## Check bad DT_STRTAB address.
+
+# RUN: yaml2obj %s -DSTRSZ_VALUE=0x0000000000000001 -DSTRTAB_ADDR=0x0000000000000260 -o %t
+# RUN: not llvm-ifs --input-format=ELF --output-ifs=%t.tbe %t 2>&1 | FileCheck %s -DERR_ADDR=0x260
+
+
+## Check bad DT_STRSZ size.
+
+# RUN: yaml2obj %s -DSTRSZ_VALUE=0x0000000000001000 -DSTRTAB_ADDR=0x0000000000001000 -o %t
+# RUN: not llvm-ifs --input-format=ELF --output-ifs=%t.tbe %t 2>&1 | FileCheck %s -DERR_ADDR=0x2000
 
 !ELF
 FileHeader:
   Class:           ELFCLASS64
   Data:            ELFDATA2LSB
   Type:            ET_DYN
   Machine:         EM_X86_64
 Sections:
   - Name:            .dynstr
     Type:            SHT_STRTAB
     Flags:           [ SHF_ALLOC ]
     Address:         0x1000
     Content:         "00"
   - Name:            .dynamic
     Type:            SHT_DYNAMIC
     Flags:           [ SHF_ALLOC ]
     Address:         0x0000000000001008
     Link:            .dynstr
     AddressAlign:    0x0000000000000008
     EntSize:         0x0000000000000010
     Entries:
       - Tag:             DT_SONAME
         Value:           0x0000000000000000
       - Tag:             DT_STRSZ
-        Value:           0x0000000000000001
+        Value:           [[STRSZ_VALUE]]
       - Tag:             DT_STRTAB
-        Value:           0x0000000000000260 # Bad vaddr (no PT_LOAD for 0x0000 to 0x0FFF)
+        Value:           [[STRTAB_ADDR]]
       - Tag:             DT_SYMTAB
         Value:           0x0000000000001000
       - Tag:             DT_NULL
         Value:           0x0000000000000000
 ProgramHeaders:
   - Type:     PT_LOAD
     Flags:    [ PF_R ]
     VAddr:    0x1000
     Align:    8
     FirstSec: .dynstr
     LastSec:  .dynamic
   - Type:     PT_DYNAMIC
     Flags:    [ PF_X, PF_R ]
     VAddr:    0x1008
     FirstSec: .dynamic
     LastSec:  .dynamic
 
-# CHECK: virtual address is not in any segment: 0x260 when locating dynamic string table section contents
+# CHECK: virtual address is not in any segment: [[ERR_ADDR]] when locating dynamic string table section contents