This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
compiler-rt/lib/hwasan/
-
lib/
-
hwasan/
-
hwasan.cpp

Differential D119570

hwasan: fix up includes
ClosedPublic

Authored by dvyukov on Feb 11 2022, 11:39 AM.

Download Raw Diff

Details

Reviewers

melver
vitalybuka
thakis
paulkirth

Commits

rG54e96ac835f2: hwasan: fix up includes

Summary

Fix up includes after 595d340dceca
("sanitizer_common: make internal/external headers compatible").

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

dvyukov requested review of this revision.Feb 11 2022, 11:39 AM

dvyukov created this revision.

Herald added a project: Restricted Project. · View Herald TranscriptFeb 11 2022, 11:39 AM

Herald added a subscriber: Restricted Project. · View Herald Transcript

dvyukov mentioned this in D119546: sanitizer_common: make internal/external headers compatible.Feb 11 2022, 11:40 AM

This revision was not accepted when it landed; it landed in state Needs Review.Feb 11 2022, 11:41 AM

This revision was landed with ongoing or failed builds.

Closed by commit rG54e96ac835f2: hwasan: fix up includes (authored by dvyukov). · Explain Why

This revision was automatically updated to reflect the committed changes.

dvyukov added a commit: rG54e96ac835f2: hwasan: fix up includes.

Harbormaster completed remote builds in B149042: Diff 407970.Feb 11 2022, 11:50 AM

thanks! that fixed things.

FYI I sent https://reviews.llvm.org/rG11b0506c08897a132b1b810be4ca71c3d605c7e9 for another missing include in memprof.

We're actually still seeing breakages, though they are different.

I sent out a patch in https://reviews.llvm.org/D119588 to patch a fuchsia specific test, but I'm now seeing similar breakages on mac(https://luci-milo.appspot.com/ui/p/fuchsia/builders/toolchain.ci/clang-mac-x64/b8822486856803675585/overview), which required https://reviews.llvm.org/D119598.

In all of these cases, it seems like the sanitizer_interface_internal.h header is required. I think this is going to be a problem for any file that was relying on the transitive includes from the base patch.

Revision Contents

Path

Size

compiler-rt/

lib/

hwasan/

hwasan.cpp

1 line

Diff 407971

compiler-rt/lib/hwasan/hwasan.cpp

	Show All 19 Lines
	#include "hwasan_poisoning.h"			#include "hwasan_poisoning.h"
	#include "hwasan_report.h"			#include "hwasan_report.h"
	#include "hwasan_thread.h"			#include "hwasan_thread.h"
	#include "hwasan_thread_list.h"			#include "hwasan_thread_list.h"
	#include "sanitizer_common/sanitizer_atomic.h"			#include "sanitizer_common/sanitizer_atomic.h"
	#include "sanitizer_common/sanitizer_common.h"			#include "sanitizer_common/sanitizer_common.h"
	#include "sanitizer_common/sanitizer_flag_parser.h"			#include "sanitizer_common/sanitizer_flag_parser.h"
	#include "sanitizer_common/sanitizer_flags.h"			#include "sanitizer_common/sanitizer_flags.h"
				#include "sanitizer_common/sanitizer_interface_internal.h"
	#include "sanitizer_common/sanitizer_libc.h"			#include "sanitizer_common/sanitizer_libc.h"
	#include "sanitizer_common/sanitizer_procmaps.h"			#include "sanitizer_common/sanitizer_procmaps.h"
	#include "sanitizer_common/sanitizer_stackdepot.h"			#include "sanitizer_common/sanitizer_stackdepot.h"
	#include "sanitizer_common/sanitizer_stacktrace.h"			#include "sanitizer_common/sanitizer_stacktrace.h"
	#include "sanitizer_common/sanitizer_symbolizer.h"			#include "sanitizer_common/sanitizer_symbolizer.h"
	#include "ubsan/ubsan_flags.h"			#include "ubsan/ubsan_flags.h"
	#include "ubsan/ubsan_init.h"			#include "ubsan/ubsan_init.h"

	▲ Show 20 Lines • Show All 564 Lines • Show Last 20 Lines