This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Add papers from February 2022 plenary meeting
ClosedPublic

Authored by philnik on Feb 7 2022, 1:48 PM.

Diff Detail

Event Timeline

philnik requested review of this revision.Feb 7 2022, 1:48 PM
philnik created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 7 2022, 1:48 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
philnik updated this revision to Diff 406791.Feb 8 2022, 6:01 AM
  • Also add feature test macros
  • Fix CI

Thanks for updating the feature macros at the same time as the csv! We should get in that habit. :)
LGTM%comment, but I did not exhaustively double-check anything.

libcxx/utils/generate_feature_test_macro_components.py
238

This should say __cpp_lib_constexpr_cmath, according to http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p0533r9.pdf . (This is the only one I spot-checked, because it smelled wrong — the name of the header is <cmath>, not <math>. I did not check the others.)

Thanks for doing this. A question do you want to update the accepted LWG-issues in this patch or a separate patch?

Thanks a lot for doing this! Would you have any appetite for adding the LWG issues in this patch as well?

libcxx/utils/generate_feature_test_macro_components.py
152

Where did you find this one? It wasn't in the Feb meeting, right?

philnik updated this revision to Diff 406957.Feb 8 2022, 1:34 PM
philnik marked 2 inline comments as done.
  • Fix feature test macro name

Thanks a lot for doing this! Would you have any appetite for adding the LWG issues in this patch as well?

I can make a separate PR once https://wg21.link is back online again.

libcxx/utils/generate_feature_test_macro_components.py
152

It's part of P2387R3.

ldionne accepted this revision.Feb 8 2022, 1:56 PM

Thanks!

This revision is now accepted and ready to land.Feb 8 2022, 1:56 PM
philnik updated this revision to Diff 406980.Feb 8 2022, 2:38 PM
  • Move feature test macro
philnik updated this revision to Diff 406991.Feb 8 2022, 3:07 PM
  • Run ninja libcxx-generate-files
This revision was automatically updated to reflect the committed changes.