Details
- Reviewers
ldionne • Quuxplusone Mordante - Group Reviewers
Restricted Project - Commits
- rGa5b4479d3c93: [libc++] Add papers from February 2022 plenary meeting
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Thanks for updating the feature macros at the same time as the csv! We should get in that habit. :)
LGTM%comment, but I did not exhaustively double-check anything.
libcxx/utils/generate_feature_test_macro_components.py | ||
---|---|---|
238 | This should say __cpp_lib_constexpr_cmath, according to http://www.open-std.org/jtc1/sc22/wg21/docs/papers/2021/p0533r9.pdf . (This is the only one I spot-checked, because it smelled wrong — the name of the header is <cmath>, not <math>. I did not check the others.) |
Thanks for doing this. A question do you want to update the accepted LWG-issues in this patch or a separate patch?
Thanks a lot for doing this! Would you have any appetite for adding the LWG issues in this patch as well?
libcxx/utils/generate_feature_test_macro_components.py | ||
---|---|---|
152 | Where did you find this one? It wasn't in the Feb meeting, right? |
I can make a separate PR once https://wg21.link is back online again.
libcxx/utils/generate_feature_test_macro_components.py | ||
---|---|---|
152 | It's part of P2387R3. |
Where did you find this one? It wasn't in the Feb meeting, right?