[lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON

[mceier]

Summary

When LLVM_ENABLE_ZLIB is ON gdb-remote should link with ZLIB::ZLIB.

Fixes https://reviews.llvm.org/D119058#3301524

[JDevlieghere]

We should add this to LLDB_SYSTEM_LIBS like we do in lldb/source/Host/CMakeLists.txt and include ${LLDB_SYSTEM_LIBS} for lldbPluginProcessGDBRemote.

[JDevlieghere]

Basically it should mirror what we have for LZMA:

if (LLDB_ENABLE_LZMA)
  list(APPEND EXTRA_LIBS ${LIBLZMA_LIBRARIES})
endif()

[mceier]

In D119186#3302612, @JDevlieghere wrote:

We should add this to LLDB_SYSTEM_LIBS like we do in lldb/source/Host/CMakeLists.txt and include ${LLDB_SYSTEM_LIBS} for lldbPluginProcessGDBRemote.

So should I add:

if(LLVM_ENABLE_ZLIB)
  list(APPEND LLDB_SYSTEM_LIBS ZLIB::ZLIB)
endif()

to lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt or do you have different CMakeLists.txt file in mind ?

[JDevlieghere]

In D119186#3302765, @mceier wrote:

In D119186#3302612, @JDevlieghere wrote:

We should add this to LLDB_SYSTEM_LIBS like we do in lldb/source/Host/CMakeLists.txt and include ${LLDB_SYSTEM_LIBS} for lldbPluginProcessGDBRemote.

So should I add:

if(LLVM_ENABLE_ZLIB)
  list(APPEND LLDB_SYSTEM_LIBS ZLIB::ZLIB)
endif()

to lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt or do you have different CMakeLists.txt file in mind ?

Yup that's fine. I think at some point we'll want to centralize all these dependencies somewhere higher up and have it shared by the different targets, but that's definitely for a separate patch.

[raj.khem]

I tested this patch and it fixes lldb build. Thanks for taking care of this,.

[mceier]

Updated diff to use LLDB_SYSTEM_LIBS

[JDevlieghere]

Thanks! LGTM.

[mceier]

I need someone to merge it for me.

[MaskRay]

In D119186#3303530, @mceier wrote:

I need someone to merge it for me.

Testing and merging.

edit: merged into release/14.x as well.

[sylvestre.ledru]

Debian is still broken with this patch on -14:

lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): error: undefined reference to 'inflateInit2_' lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): error: undefined reference to 'inflate' lib/liblldbPluginProcessGDBRemote.a(GDBRemoteCommunication.cpp.o):GDBRemoteCommunication.cpp:function lldb_private::process_gdb_remote::GDBRemoteCommunication::DecompressPacket(): error: undefined reference to 'inflateEnd'

[sylvestre.ledru]

Log:
https://llvm-jenkins.debian.net/job/llvm-toolchain-impish-14-binaries/12/architecture=amd64,distribution=impish,label=amd64/console

[mceier]

In D119186#3303744, @sylvestre.ledru wrote:

Log:
https://llvm-jenkins.debian.net/job/llvm-toolchain-impish-14-binaries/12/architecture=amd64,distribution=impish,label=amd64/console

I downloaded build artifacts and it doesn't seem this patch was applied in this build. I grepped for ZLIB::ZLIB and only lld had it.

lldb/source/Plugins/Process/gdb-remote/CMakeLists.txt

set(LLDB_PLUGINS
   lldbPluginProcessUtility
   lldbPluginPlatformMacOSX
 )
 
 if(HAVE_LIBCOMPRESSION)
   set(LIBCOMPRESSION compression)
 endif()
 
+if(LLVM_ENABLE_ZLIB)
+  list(APPEND LLDB_SYSTEM_LIBS ZLIB::ZLIB)
+endif()
+
 add_lldb_library(lldbPluginProcessGDBRemote PLUGIN
   GDBRemoteClientBase.cpp
   GDBRemoteCommunication.cpp
   GDBRemoteCommunicationClient.cpp
   GDBRemoteCommunicationHistory.cpp
   GDBRemoteCommunicationServer.cpp
   GDBRemoteCommunicationServerCommon.cpp
   GDBRemoteCommunicationServerLLGS.cpp
   GDBRemoteCommunicationServerPlatform.cpp
   GDBRemoteRegisterContext.cpp
   GDBRemoteRegisterFallback.cpp
   ProcessGDBRemote.cpp
   ProcessGDBRemoteLog.cpp
   ThreadGDBRemote.cpp
 
   LINK_LIBS
     lldbBreakpoint
     lldbCore
     lldbDataFormatters
     lldbHost
     lldbInterpreter
     lldbSymbol
     lldbTarget
     lldbUtility
+    ${LLDB_SYSTEM_LIBS}
     ${LLDB_PLUGINS}
     ${LIBCOMPRESSION}
   LINK_COMPONENTS
     Support
   )
 
 add_dependencies(lldbPluginProcessGDBRemote
   LLDBPluginProcessGDBRemotePropertiesGen
   LLDBPluginProcessGDBRemotePropertiesEnumGen)