Page MenuHomePhabricator

Please use GitHub pull requests for new patches. Phabricator shutdown timeline

mceier (Mariusz Ceier)
User

Projects

User does not belong to any projects.

User Details

User Since
Oct 30 2020, 1:03 PM (151 w, 1 d)

Recent Activity

Dec 28 2022

mceier added a comment to D127812: [AArch64] FMV support and necessary target features dependencies..

Checked the changes I'm suggesting and they fix the standalone build.

Dec 28 2022, 8:01 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 25 2022

mceier accepted D138274: Add version to all LLVM cmake package.
Nov 25 2022, 7:06 AM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Nov 24 2022

mceier added inline comments to D138274: Add version to all LLVM cmake package.
Nov 24 2022, 12:59 PM · Restricted Project, Restricted Project, Restricted Project, Restricted Project

Apr 19 2022

mceier added a comment to D120544: [AMDGPU] Omit unnecessary waitcnt before barriers.

Can you post the IR and ISA for the failing shader?

Apr 19 2022, 11:58 AM · Restricted Project, Restricted Project

Apr 18 2022

mceier added a comment to D120544: [AMDGPU] Omit unnecessary waitcnt before barriers.

Can you post the IR and ISA for the failing shader?

Apr 18 2022, 1:39 PM · Restricted Project, Restricted Project
mceier added a comment to D120544: [AMDGPU] Omit unnecessary waitcnt before barriers.

This revision causes gpu hangups (Radeon 5700XT) on linux in many opengl apps, for example for godot I get something like this in dmesg:

Apr 18 2022, 2:25 AM · Restricted Project, Restricted Project

Feb 8 2022

mceier added a comment to D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON.
Feb 8 2022, 2:25 AM · Restricted Project

Feb 7 2022

mceier accepted D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON.

I need someone to merge it for me.

Feb 7 2022, 11:01 PM · Restricted Project
mceier updated the diff for D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON.

Updated diff to use LLDB_SYSTEM_LIBS

Feb 7 2022, 10:16 PM · Restricted Project
mceier added a comment to D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON.

We should add this to LLDB_SYSTEM_LIBS like we do in lldb/source/Host/CMakeLists.txt and include ${LLDB_SYSTEM_LIBS} for lldbPluginProcessGDBRemote.

Feb 7 2022, 2:42 PM · Restricted Project
mceier added a comment to D119058: Fix lld standalone build.

Move LLVM_ENABLE_ZLIB

this change breaks lldb builds

Feb 7 2022, 1:49 PM · Restricted Project, lld
mceier requested review of D119186: [lldb][gdb-remote] Fix linking of gdb-remote when LLVM_ENABLE_ZLIB is ON.
Feb 7 2022, 1:43 PM · Restricted Project
mceier accepted D119058: Fix lld standalone build.

Not sure who's supposed to push it. I can't since I don't have github account. I can only "Accept Revision".

Feb 7 2022, 5:19 AM · Restricted Project, lld

Feb 5 2022

mceier requested review of D119058: Fix lld standalone build.
Feb 5 2022, 4:04 AM · Restricted Project, lld

Sep 7 2021

mceier accepted D109352: [OpenMP] [OMPD] OPENMP_INSTALL_LIBDIR is set for the install dir.

I confirm this patch fixes the multilib issue on my system.

Sep 7 2021, 6:50 AM · Restricted Project

Sep 3 2021

mceier added inline comments to D100182: [OpenMP] [OMPD] [2/6] Implementation of OMPD debugging library - libompd. TargetValue: Access OpenMP runtime state through callbacks provided by tool.
Sep 3 2021, 10:07 AM · Restricted Project

May 14 2021

mceier updated the diff for D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Added LLVM_ prefix to all occurrences of HAVE_LIBXAR; fixed one missing char.

May 14 2021, 2:12 PM · Restricted Project, Restricted Project
mceier added a comment to D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Sorry about the delay here.

May 14 2021, 10:57 AM · Restricted Project, Restricted Project

May 10 2021

mceier requested review of D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Looks great. Do you need me to land this for you, or can you commit yourself?

May 10 2021, 8:30 AM · Restricted Project, Restricted Project

May 8 2021

mceier updated the diff for D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Verified that standalone lld builds with HAVE_LIBXAR set and unset.
Added HAVE_LIBXAR to LLVMConfig.cmake and linking liblldMachO2.so with XAR_LIB if HAVE_LIBXAR is set.

May 8 2021, 12:53 AM · Restricted Project, Restricted Project
mceier updated the diff for D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Added missing word in a comment for HAVE_LIBXAR define

May 8 2021, 12:01 AM · Restricted Project, Restricted Project

May 7 2021

mceier updated the diff for D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Moved HAVE_LIBXAR from config.h to llvm-config.h

May 7 2021, 11:45 AM · Restricted Project, Restricted Project
mceier added a comment to D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.

Wait, this isn't right, is it? We need this for #ifndef HAVE_LIBXAR and HAVE_LIBXAR is in config.h but not in llvm-config.h. This will silently break HAVE_LIBXAR checks.

May 7 2021, 11:11 AM · Restricted Project, Restricted Project
mceier requested review of D102084: Fix lld macho standalone build by including llvm/Config/llvm-config.h instead of llvm/Config/config.h.
May 7 2021, 10:41 AM · Restricted Project, Restricted Project

Nov 26 2020

mceier updated the diff for D92158: Also include component groups in llvm-config --components list.

Renamed llvm_target_to_build to llvm_component

Nov 26 2020, 1:03 AM · Restricted Project
mceier requested review of D92158: Also include component groups in llvm-config --components list.
Nov 26 2020, 12:47 AM · Restricted Project

Nov 24 2020

mceier added inline comments to D86495: [CSSPGO] MIR target-independent pseudo instruction for pseudo-probe intrinsic.
Nov 24 2020, 3:28 PM · Restricted Project
mceier added inline comments to D86495: [CSSPGO] MIR target-independent pseudo instruction for pseudo-probe intrinsic.
Nov 24 2020, 1:04 PM · Restricted Project
mceier added inline comments to D86495: [CSSPGO] MIR target-independent pseudo instruction for pseudo-probe intrinsic.
Nov 24 2020, 12:10 AM · Restricted Project

Nov 7 2020

mceier accepted D90997: [AMDGPU] SIWholeQuadMode fix mode insertion when SCC always defined.

I confirm this fixes the llc and CS:GO crash from D88081

Nov 7 2020, 1:05 AM · Restricted Project

Nov 6 2020

mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Nov 6 2020, 6:07 AM · Restricted Project
mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Nov 6 2020, 5:25 AM · Restricted Project

Nov 5 2020

mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Nov 5 2020, 11:53 AM · Restricted Project
mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Nov 5 2020, 11:49 AM · Restricted Project
mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Nov 5 2020, 6:02 AM · Restricted Project

Oct 30 2020

mceier added inline comments to D88081: [AMDGPU] Move WQM Pass after MI Scheduler.
Oct 30 2020, 1:18 PM · Restricted Project