This is an archive of the discontinued LLVM Phabricator instance.

[llvm] [Debuginfod] Remove `llvm-debuginfod-find` lit tests that used python http server.
ClosedPublic

Authored by noajshu on Feb 6 2022, 3:07 PM.

Details

Summary

These tests depend on ThreadingHTTPServer which was not introduced until python 3.7 so we might as well delete them to avoid issues.

Diff Detail

Event Timeline

noajshu requested review of this revision.Feb 6 2022, 3:07 PM
noajshu created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFeb 6 2022, 3:07 PM
Herald added a project: Restricted Project. · View Herald TranscriptMar 31 2022, 3:34 PM
noajshu edited the summary of this revision. (Show Details)Mar 31 2022, 3:34 PM
noajshu added a reviewer: Hahnfeld.

I don't know if simply removing the tests is the right course of action, but yes I'd really love to get a clean check-all with Python 3.6

mysterymath accepted this revision.Aug 15 2022, 2:18 PM

Sorry for the long delay; it looks like most of this functionality is now covered by the llvm-debuginfod.test for the debuginfod server. LGTM.

This revision is now accepted and ready to land.Aug 15 2022, 2:18 PM
This revision was landed with ongoing or failed builds.Aug 29 2022, 6:33 PM
This revision was automatically updated to reflect the committed changes.