This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Do not use an empty source file when building aggregate libraries.
ClosedPublic

Authored by stellaraccident on Feb 5 2022, 10:05 PM.

Details

Summary

See discussion: https://discourse.llvm.org/t/check-mlir-times-examples-standalone-testing-time/6073/7

It turns out that it has been legal since CMake 3.11 to omit sources at library creation time if they are added later via target_sources, as is done here. This side-steps the issue of having a file that changes and invalidates the build of leaves.

Diff Detail