Fix LookupTest where it was missing an assertion

[probinson]

Summary

The preceding EXPECT_EQ was never executed; modifying the test input
made that happen.

Found by the Rotten Green Tests project.

[probinson]

By "the EXPECT_EQ was never executed" I mean, replacing it with assert(false); does not crash the test. The string "a::b::Foo" was never seen by the Visitor.

Maybe this indicates some much more subtle, deeper problem; I don't know. This change does cause the EXPECT_EQ to be executed, though.

[probinson]

Ping; +@kadircet

[probinson]

Ping; + @bkramer who reviewed the original patch that added this test.

[probinson]

+ @hokein who has done work in the one place where replaceNestedName is used.

[kadircet]

Thanks for the change, but the test is actually checking for rename in presence of using-decls. I beleive https://reviews.llvm.org/D121103 is the proper fix here.

[probinson]

In D119040#3363406, @kadircet wrote:

Thanks for the change, but the test is actually checking for rename in presence of using-decls. I beleive https://reviews.llvm.org/D121103 is the proper fix here.

Awesome, thanks! Abandoning this one.

clang/unittests/Tooling/LookupTest.cpp

Visitor.OnRecordTypeLoc = [&](RecordTypeLoc Type) {
     // Filter Types by name since there are other `RecordTypeLoc` in the test
     // file.
     // `a::b::Foo` in using shadow decl is not `TypeLoc`.
     if (Type.getDecl()->getQualifiedNameAsString() == "a::b::Foo") {
       EXPECT_EQ("Bar", replaceRecordTypeLoc(Type, "::a::x::Bar"));
     }
   };
   Visitor.runOver("namespace a { namespace b { class Foo {}; } }\n"
-                  "namespace c { using a::b::Foo; Foo f();; }\n");
+                  "namespace c { a::b::Foo f();; }\n");
 
   // Rename TypeLoc `x::y::Old` to new name `x::Foo` at [0] and check that the
   // type is replaced with "Foo" instead of "x::Foo". Although there is a symbol
   // `x::y::Foo` in c.cc [1], it should not make "Foo" at [0] ambiguous because
   // it's not visible at [0].
   Visitor.OnRecordTypeLoc = [&](RecordTypeLoc Type) {
     if (Type.getDecl()->getQualifiedNameAsString() == "x::y::Old") {
       EXPECT_EQ("Foo", replaceRecordTypeLoc(Type, "::x::Foo"));