This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Replace includes of <utility> with specific detail headers
ClosedPublic

Authored by Quuxplusone on Feb 4 2022, 10:17 AM.

Details

Summary

Basically a rebase of D104980; most of that patch had already happened
via gradual drive-by changes, but this finishes it up.
Don't touch the inclusions from <__functional_base>, <__hash_table>,
or <__locale>; those could be removed if we propagated the
inclusions up to the includers of those files, but there are lots
of those includers.

<algorithm>, <functional>, and <memory> already include <utility>
at the top level. <iterator> did not, so I've added it there.

Diff Detail

Event Timeline

Quuxplusone requested review of this revision.Feb 4 2022, 10:17 AM
Quuxplusone created this revision.
Herald added 1 blocking reviewer(s): Restricted Project. · View Herald TranscriptFeb 4 2022, 10:17 AM
Mordante accepted this revision as: Mordante.Feb 4 2022, 11:19 AM

LGTM after the CI passes. When this replaces D104980 can you commandeer and abandon that review?

philnik accepted this revision.Feb 4 2022, 12:50 PM

Looks like you have some include-order problems :D . LGTM.

This revision is now accepted and ready to land.Feb 4 2022, 12:50 PM

Fix include order. :)

ldionne accepted this revision.Feb 4 2022, 1:06 PM