[clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

[kuzkry]

Summary

[clang-format][docs] Fix incorrect 'clang-format 14' configuration options markers

Introduced by 23a5090c6, some style option markers indicated 'clang-format 14',
though their respective options were available in earlier releases.

Note: Even though the value type of 'SpacesInAngles' option changed,
this option has been already present from version 3.4.

[MyDeveloperDay]

Thank you for looking into this, I'm more than happy for us to change the values to their more accurate first releases, but can I ask how you went about making those assumptions? For me initially I simply looks at the commit in the blame then tracked that to what branches it was in. I always knew it would be inaccurate.

What was your technique for doing this?

[MyDeveloperDay]

Thank you for this. LGTM (I double-checked a few and they all look good to me!)

clang/docs/ClangFormatStyleOptions.rst

2212

agreed its here
https://releases.llvm.org/13.0.0/tools/clang/docs/ClangFormatStyleOptions.html

2378

Agreed
https://releases.llvm.org/13.0.0/tools/clang/docs/ClangFormatStyleOptions.html

3130

Agreed, https://reviews.llvm.org/D103286

3374

Agreed https://reviews.llvm.org/D104096

3538

Agreed https://reviews.llvm.org/D87587

[kuzkry]

Hey @MyDeveloperDay,

Thank you for your positive feedback :)

You asked about my technique. Well, I did it empirically. There is a really splendid repository on GitHub by muttleyxd, i.e. https://github.com/muttleyxd/clang-tools-static-binaries. What muttleyxd did is he automated the task of compiling all major versions of clang tools (including clang-format) and he released it in form of static binaries to avoid problems with dependencies (they are really small though). Btw. I recommend you to at least save this as a bookmark in your web browser.

Having downloaded clang-format in versions 3.9 and from 4.0 to 13.0, I simply manually ran those binaries and looked for "unknown key" errors. I did that only for all options marked with "clang-format 14" tag, i.e.:
EmptyLineAfterAccessModifier
IfMacros
PPIndentWidth
PackConstructorInitializers
PenaltyBreakOpenParenthesis
QualifierAlignment
QualifierOrder
ReferenceAlignment
RemoveBracesLLVM
SeparateDefinitionBlocks
ShortNamespaceLines
SpaceBeforeParensOptions
SpacesInAngles
SpacesInLineCommentPrefix

The only problem I got was SpacesInAngles, which I actually checked using your technique, i.e. git-based rather than empirical one. I had to make it like that cause it was already available before 3.9, which is the earliest in muttleyxd's repository.

[MyDeveloperDay]

Do you need someone to land this for you? if so we need your "name <email_address>"

[kuzkry]

In D118991#3298823, @MyDeveloperDay wrote:

Do you need someone to land this for you? if so we need your "name <email_address>"

Yes, I need someone to do that. Could you do this for me, please? It's "Krystian Kuzniarek <[e-mail]>". Thanks in advance.

P.S. I plan to continue with similar work in decreasing order of clang-format versions so firstly for "clang-format 13", secondly for 12, then 11, etc. If I find some more inaccuracies, I will prepare new Phabricator reviews for you.

clang/docs/ClangFormatStyleOptions.rst

**DerivePointerAlignment** (``Boolean``) :versionbadge:`clang-format 3.7`
   alignment of ``&`` and ``*``.
   Pointer and reference alignment styles are going to be updated according
   to the preferences found in the file.
   ``PointerAlignment`` is then used only as fallback.
 
 **DisableFormat** (``Boolean``) :versionbadge:`clang-format 3.7`
   Disables formatting completely.
 
-**EmptyLineAfterAccessModifier** (``EmptyLineAfterAccessModifierStyle``) :versionbadge:`clang-format 14`
+**EmptyLineAfterAccessModifier** (``EmptyLineAfterAccessModifierStyle``) :versionbadge:`clang-format 13`
   Defines when to put an empty line after access modifiers.
   ``EmptyLineBeforeAccessModifier`` configuration handles the number of
   empty lines between two access modifiers.
 
   Possible values:
 
   * ``ELAAMS_Never`` (in configuration: ``Never``)
     Remove all empty lines after access modifiers.
**ForEachMacros** (``List of Strings``) :versionbadge:`clang-format 3.7`
   In the .clang-format configuration file, this can be configured like:
 
   .. code-block:: yaml
 
     ForEachMacros: ['RANGES_FOR', 'FOREACH']
 
   For example: BOOST_FOREACH.
 
-**IfMacros** (``List of Strings``) :versionbadge:`clang-format 14`
+**IfMacros** (``List of Strings``) :versionbadge:`clang-format 13`
   A vector of macros that should be interpreted as conditionals
   instead of as function calls.
 
   These are expected to be macros of the form:
 
   .. code-block:: c++
 
     IF(...)

 **ObjCSpaceAfterProperty** (``Boolean``) :versionbadge:`clang-format 3.7`
   Add a space after ``@property`` in Objective-C, i.e. use
   ``@property (readonly)`` instead of ``@property(readonly)``.
 
 **ObjCSpaceBeforeProtocolList** (``Boolean``) :versionbadge:`clang-format 3.7`
   Add a space in front of an Objective-C protocol list, i.e. use
   ``Foo <Protocol>`` instead of ``Foo<Protocol>``.
 
-**PPIndentWidth** (``Integer``) :versionbadge:`clang-format 14`
+**PPIndentWidth** (``Integer``) :versionbadge:`clang-format 13`
   The number of columns to use for indentation of preprocessor statements.
   When set to -1 (default) ``IndentWidth`` is used also for preprocessor
   statements.
 
   .. code-block:: c++
 
      PPIndentWidth: 1
 
RawStringFormats:
           BasedOnStyle: google
       - Language: Cpp
           Delimiters:
             - 'cc'
             - 'cpp'
           BasedOnStyle: llvm
           CanonicalDelimiter: 'cc'
 
-**ReferenceAlignment** (``ReferenceAlignmentStyle``) :versionbadge:`clang-format 14`
+**ReferenceAlignment** (``ReferenceAlignmentStyle``) :versionbadge:`clang-format 13`
   Reference alignment style (overrides ``PointerAlignment`` for
   references).
 
   Possible values:
 
   * ``RAS_Pointer`` (in configuration: ``Pointer``)
     Align reference like ``PointerAlignment``.
 
**SeparateDefinitionBlocks** (``SeparateDefinitionStyle``) :versionbadge:`clang-format 14`
   * ``SDS_Always`` (in configuration: ``Always``)
     Insert an empty line between definition blocks.
 
   * ``SDS_Never`` (in configuration: ``Never``)
     Remove any empty line between definition blocks.
 
 
 
-**ShortNamespaceLines** (``Unsigned``) :versionbadge:`clang-format 14`
+**ShortNamespaceLines** (``Unsigned``) :versionbadge:`clang-format 13`
   The maximal number of unwrapped lines that a short namespace spans.
   Defaults to 1.
 
   This determines the maximum length of short namespaces by counting
   unwrapped lines (i.e. containing neither opening nor closing
   namespace brace) and makes "FixNamespaceComments" omit adding
   end comments for those.
 
.. code-block:: c++
 
      SpacesBeforeTrailingComments: 3
      void f() {
        if (true) {   // foo1
          f();        // bar
        }             // foo
      }
 
-**SpacesInAngles** (``SpacesInAnglesStyle``) :versionbadge:`clang-format 14`
+**SpacesInAngles** (``SpacesInAnglesStyle``) :versionbadge:`clang-format 3.4`
   The SpacesInAnglesStyle to use for template argument lists.
 
   Possible values:
 
   * ``SIAS_Never`` (in configuration: ``Never``)
     Remove spaces after ``<`` and before ``>``.
 
     .. code-block:: c++
**SpacesInContainerLiterals** (``Boolean``) :versionbadge:`clang-format 3.7`
   ObjC and Javascript array and dict literals).
 
   .. code-block:: js
 
      true:                                  false:
      var arr = [ 1, 2, 3 ];         vs.     var arr = [1, 2, 3];
      f({a : 1, b : 2, c : 3});              f({a: 1, b: 2, c: 3});
 
-**SpacesInLineCommentPrefix** (``SpacesInLineComment``) :versionbadge:`clang-format 14`
+**SpacesInLineCommentPrefix** (``SpacesInLineComment``) :versionbadge:`clang-format 13`
   How many spaces are allowed at the start of a line comment. To disable the
   maximum set it to ``-1``, apart from that the maximum takes precedence
   over the minimum.
 
   .. code-block:: c++
 
     Minimum = 1
     Maximum = -1

clang/include/clang/Format/Format.h

enum EmptyLineAfterAccessModifierStyle : unsigned char {
     ///   };
     /// \endcode
     ELAAMS_Always,
   };
 
   /// Defines when to put an empty line after access modifiers.
   /// ``EmptyLineBeforeAccessModifier`` configuration handles the number of
   /// empty lines between two access modifiers.
-  /// \version 14
+  /// \version 13
   EmptyLineAfterAccessModifierStyle EmptyLineAfterAccessModifier;
 
   /// Different styles for empty line before access modifiers.
   enum EmptyLineBeforeAccessModifierStyle : unsigned char {
     /// Remove all empty lines before access modifiers.
     /// \code
     ///   struct foo {
     ///   private:

   ///
   /// In the .clang-format configuration file, this can be configured like:
   /// \code{.yaml}
   ///   IfMacros: ['IF']
   /// \endcode
   ///
   /// For example: `KJ_IF_MAYBE
   /// <https://github.com/capnproto/capnproto/blob/master/kjdoc/tour.md#maybes>`_
-  /// \version 14
+  /// \version 13
   std::vector<std::string> IfMacros;
 
   /// \brief A vector of macros that should be interpreted as type declarations
   /// instead of as function calls.
   ///
   /// These are expected to be macros of the form:
   /// \code
   ///   STACK_OF(...)
///    NS_TABLE_.*_END$"
   ///    PPIndentWidth: 1
   ///
   ///    #ifdef __linux__
   ///    # define FOO
   ///    #else
   ///    # define BAR
   ///    #endif
   /// \endcode
-  /// \version 14
+  /// \version 13
   int PPIndentWidth;
 
   /// See documentation of ``RawStringFormats``.
   struct RawStringFormat {
     /// The language of this raw string.
     LanguageKind Language;
     /// A list of raw string delimiters that match this language.
     std::vector<std::string> Delimiters;
enum ReferenceAlignmentStyle {
     /// \code
     ///   int & a;
     /// \endcode
     RAS_Middle
   };
 
   /// \brief Reference alignment style (overrides ``PointerAlignment`` for
   /// references).
-  /// \version 14
+  /// \version 13
   ReferenceAlignmentStyle ReferenceAlignment;
 
   // clang-format off
   /// If ``true``, clang-format will attempt to re-flow comments.
   /// \code
   ///    false:
   ///    // veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongComment with plenty of information
   ///    /* second veryVeryVeryVeryVeryVeryVeryVeryVeryVeryVeryLongComment with plenty of information */
///    NS_TABLE_.*_END$"
   ///    }                                  } // namespace a
   ///
   ///    ShortNamespaceLines: 1     vs.     ShortNamespaceLines: 0
   ///    namespace b {                      namespace b {
   ///      int foo;                           int foo;
   ///      int bar;                           int bar;
   ///    } // namespace b                   } // namespace b
   /// \endcode
-  /// \version 14
+  /// \version 13
   unsigned ShortNamespaceLines;
 
   /// Include sorting options.
   enum SortIncludesOptions : unsigned char {
     /// Includes are never sorted.
     /// \code
     ///    #include "B/A.h"
     ///    #include "A/B.h"
enum SpacesInAnglesStyle : unsigned char {
     ///    std::function< void(int) > fct;
     /// \endcode
     SIAS_Always,
     /// Keep a single space after ``<`` and before ``>`` if any spaces were
     /// present. Option ``Standard: Cpp03`` takes precedence.
     SIAS_Leave
   };
   /// The SpacesInAnglesStyle to use for template argument lists.
-  /// \version 14
+  /// \version 3.4
   SpacesInAnglesStyle SpacesInAngles;
 
   /// If ``true``, spaces will be inserted around if/for/switch/while
   /// conditions.
   /// \code
   ///    true:                                  false:
   ///    if ( a )  { ... }              vs.     if (a) { ... }
   ///    while ( i < 5 )  { ... }               while (i < 5) { ... }
///    NS_TABLE_.*_END$"
   ///   //  return true;                          //   return true;
   ///   //}                                       // }
   ///
   ///   Maximum: 0
   ///   /// List:                                 ///List:
   ///   ///  - Foo                                /// - Foo
   ///   ///    - Bar                              ///   - Bar
   /// \endcode
-  /// \version 14
+  /// \version 13
   SpacesInLineComment SpacesInLineCommentPrefix;
 
   /// If ``true``, spaces will be inserted after ``(`` and before ``)``.
   /// \code
   ///    true:                                  false:
   ///    t f( Deleted & ) & = delete;   vs.     t f(Deleted &) & = delete;
   /// \endcode
   /// \version 3.7