This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Removes cpp17_output_iterator's default constructor.
ClosedPublic

Authored by Mordante on Feb 3 2022, 11:05 PM.

Details

Summary

This has been suggested in D117950.

Diff Detail

Event Timeline

Mordante created this revision.Feb 3 2022, 11:05 PM
Mordante requested review of this revision.Feb 3 2022, 11:05 PM
Herald added a project: Restricted Project. · View Herald TranscriptFeb 3 2022, 11:05 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
Mordante updated this revision to Diff 405915.Feb 4 2022, 3:50 AM

Fixing Apple builds.

Mordante added inline comments.Feb 4 2022, 3:53 AM
libcxx/test/std/localization/locale.categories/category.numeric/locale.nm.put/facet.num.put.members/put_long_double.pass.cpp
16

Interestingly this test is only executed on Apple https://buildkite.com/llvm-project/libcxx-ci/builds/8402. Looking at (partly) testing on other platforms is out of scope for this ticket.

philnik accepted this revision as: philnik.Feb 4 2022, 3:58 AM
philnik added a subscriber: philnik.

Why is put_long_double.pass.cpp so long? I didn't look at all of put_long_double.pass.cpp, but it's probably OK if CI is happy.

Why is put_long_double.pass.cpp so long? I didn't look at all of put_long_double.pass.cpp, but it's probably OK if CI is happy.

I don't know why it hasn't been written in a more compact form. But I'm don't want to fix that ;-)
Replacing the iterator was just a regex :-)

ldionne accepted this revision.Feb 4 2022, 1:14 PM
This revision is now accepted and ready to land.Feb 4 2022, 1:14 PM