This is an archive of the discontinued LLVM Phabricator instance.

Workaround _ALL_SOURCE issue on AIX
ClosedPublic

Authored by stevewan on Jan 31 2022, 8:51 AM.

Details

Summary

On AIX, many typedefs and struct definitions required by test-suite tests are only accessible when _ALL_SOURCE is set; however, setting this macro causes other side effects such as typedef redefinition. To fix this on AIX, we run test-suite with standard compatible mode (e.g., XOPEN_SOURCE=700), and use this patch to add the missing definitions to test-suite.

Event Timeline

stevewan requested review of this revision.Jan 31 2022, 8:51 AM
stevewan created this revision.
daltenty accepted this revision.Jan 31 2022, 11:34 AM

LGTM, with minor nit

MultiSource/Applications/d/d.h
79–81

nit: prefer the defined form, rather than relying on the macro value

MultiSource/Applications/viterbi/common.h
134–135

nit: same as above

This revision is now accepted and ready to land.Jan 31 2022, 11:34 AM
stevewan updated this revision to Diff 404671.Jan 31 2022, 12:30 PM

Address comments regarding assessing macro value

stevewan marked 2 inline comments as done.Jan 31 2022, 12:30 PM
This revision was automatically updated to reflect the committed changes.