This is an archive of the discontinued LLVM Phabricator instance.

[AIX][test-suite]Workaround other benchmarks affected by the _ALL_SOURCE issue on AIX
ClosedPublic

Authored by amyk on Jan 31 2022, 3:13 PM.

Details

Summary

On AIX, there are typedefs and struct definitions required by test-suite tests that are only accessible when _ALL_SOURCE is set, but setting this macro causes side effects such as typedef redefinition. To fix them on AIX, we build test-suite with standard compatible mode (e.g., XOPEN_SOURCE=700), and either add missing definitions to the tests or adjust the tests to recognize that the extensions are disabled. This patch fixes benchmarks that were not handled in D118622.

Diff Detail

Repository
rT test-suite

Event Timeline

stevewan requested review of this revision.Jan 31 2022, 3:13 PM
stevewan created this revision.
stevewan retitled this revision from Workaround other benchmarks affected by the _ALL_SOURCE issue on AIX to [AIX][test-suite]Workaround other benchmarks affected by the _ALL_SOURCE issue on AIX.Jan 31 2022, 3:18 PM
stevewan edited the summary of this revision. (Show Details)
stevewan edited the summary of this revision. (Show Details)
hubert.reinterpretcast edited the summary of this revision. (Show Details)

LGTM; thanks!

This revision is now accepted and ready to land.Jan 31 2022, 7:51 PM
amyk commandeered this revision.Nov 18 2022, 8:32 AM
amyk edited reviewers, added: stevewan; removed: amyk.
Herald added a project: Restricted Project. · View Herald TranscriptNov 18 2022, 8:32 AM