This is an archive of the discontinued LLVM Phabricator instance.

[clang][WebAssemmbly] Call TargetInfo::adjust in derived method.
ClosedPublic

Authored by sbc100 on Jan 30 2022, 11:20 AM.

Details

Summary

The superclass method handles a bunch of useful things. For example
it applies flags such as -fnew-alignment which doesn't work without
this patch.

Fixes: https://github.com/emscripten-core/emscripten/issues/16241

Diff Detail

Event Timeline

sbc100 created this revision.Jan 30 2022, 11:20 AM
sbc100 requested review of this revision.Jan 30 2022, 11:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 30 2022, 11:20 AM
sbc100 retitled this revision from [clang][WebAssemmbly]: Call TargetInfo::adjust in derived method. to [clang][WebAssemmbly] Call TargetInfo::adjust in derived method..
sbc100 edited the summary of this revision. (Show Details)Feb 10 2022, 3:50 PM

Oddly enough and emscripten user just reported an issue that this patch fixes: https://github.com/emscripten-core/emscripten/issues/16241

PTAL

dschuff accepted this revision.Feb 10 2022, 3:58 PM

Looks OK to me. All of these options handle explicit overrides to the ABI which I guess just didn't work before but doesn't change any defaults. We should probably put something in the emscripten release notes with a list of the flags that now actually do something, just in case someone was accidentally using them before :)

This revision is now accepted and ready to land.Feb 10 2022, 3:58 PM
This revision was landed with ongoing or failed builds.Feb 10 2022, 4:04 PM
This revision was automatically updated to reflect the committed changes.