[openmp][cmake] `CMAKE_INSTALL_BINDIR` usage should not be quoted

[Ericson2314]

Summary

As @mstorsjo wrote in https://reviews.llvm.org/D117945#inline-1132920 :

This change seems to have broken one aspect: When doing `ninja

install` I now get a warning saying `Error copying file "libomp.dll" to
"libiomp5md.dll"., and libiomp5md.dll` isn't installed.

I believe the reason is that the inline cmake snippet is written to

runtime/src/cmake_install.cmake and then executed on install, but on
install, ${CMAKE_INSTALL_BINDIR} isn't set (as GNUInstallDirs isn't
included there). Should this maybe expand ${CMAKE_INSTALL_BINDIR}
right here instead of deferring it to the install cmake, or what's the
right course of action?

I agree that is the right course of action. We also agreed to restore the CMAKE_INSTALL_PREFIX that was there before, too.

[Ericson2314]

Oops changed too much

[mstorsjo]

This solution turns out not to work. In this case, ${CMAKE_INSTALL_BINDIR} expands to plain bin here, which doesn't work (as that directory is meant to be relative to the install prefix. Maybe "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_BINDIR}?

[Ericson2314]

Fix more properly

[Ericson2314]

Oh yes oops. It had the \${CMAKE_INSTALL_PREFIX}/ before, so I just put that back right the way it was.

[mstorsjo]

LGTM, this works.

openmp/runtime/src/CMakeLists.txt

 endif()
 if(WIN32)
   install(TARGETS omp RUNTIME DESTINATION "${CMAKE_INSTALL_BINDIR}")
   install(TARGETS ${LIBOMP_IMP_LIB_TARGET} ARCHIVE DESTINATION "${OPENMP_INSTALL_LIBDIR}")
   # Create aliases (regular copies) of the library for backwards compatibility
   set(LIBOMP_ALIASES "libiomp5md")
   foreach(alias IN LISTS LIBOMP_ALIASES)
     install(CODE "execute_process(COMMAND \"\${CMAKE_COMMAND}\" -E copy \"${LIBOMP_LIB_FILE}\"
-      \"${alias}${LIBOMP_LIBRARY_SUFFIX}\" WORKING_DIRECTORY \"\${CMAKE_INSTALL_BINDIR}\")")
+      \"${alias}${LIBOMP_LIBRARY_SUFFIX}\" WORKING_DIRECTORY \"\${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_BINDIR}\")")
     install(CODE "execute_process(COMMAND \"\${CMAKE_COMMAND}\" -E copy \"${LIBOMP_IMP_LIB_FILE}\"
       \"${alias}${CMAKE_STATIC_LIBRARY_SUFFIX}\" WORKING_DIRECTORY \"\${CMAKE_INSTALL_PREFIX}/${OPENMP_INSTALL_LIBDIR}\")")
   endforeach()
 else()
 
   install(TARGETS omp ${LIBOMP_INSTALL_KIND} DESTINATION "${OPENMP_INSTALL_LIBDIR}")
 
   if(${LIBOMP_INSTALL_ALIASES})