This is an archive of the discontinued LLVM Phabricator instance.

Differential D118522

[OpenMP] disable build of old nvptx device runtime
ClosedPublic

Authored by ye-luo on Jan 28 2022, 5:53 PM.

Details

Reviewers
jdoerfert
JonChesterfield
Commits
rGbafb6f3e9cc7: [OpenMP] disable build of old nvptx device runtime
Summary

Fully respect LIBOMPTARGET_BUILD_NVPTX_BCLIB. There is no CUDA toolchain dependency. Complement D118268.

Diff Detail

Event Timeline

ye-luo created this revision.Jan 28 2022, 5:53 PM
Herald added subscribers: asavonic, guansong, yaxunl, mgorny. · View Herald TranscriptJan 28 2022, 5:53 PM
ye-luo requested review of this revision.Jan 28 2022, 5:53 PM
Herald added a reviewer: jdoerfert. · View Herald TranscriptJan 28 2022, 5:53 PM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: openmp-commits, sstefan1. · View Herald Transcript
ye-luo added a reviewer: JonChesterfield.Jan 28 2022, 5:54 PM
Harbormaster completed remote builds in B146412: Diff 404204.Jan 28 2022, 6:00 PM
jdoerfert accepted this revision.Jan 28 2022, 7:10 PM

LG

This revision is now accepted and ready to land.Jan 28 2022, 7:10 PM
Closed by commit rGbafb6f3e9cc7: [OpenMP] disable build of old nvptx device runtime (authored by ye-luo). · Explain WhyJan 28 2022, 7:26 PM
This revision was automatically updated to reflect the committed changes.
ye-luo added a commit: rGbafb6f3e9cc7: [OpenMP] disable build of old nvptx device runtime.
JonChesterfield added a comment.Jan 29 2022, 12:12 AM

Thanks!

Revision Contents

PathSize
openmp/
libomptarget/
deviceRTLs/
nvptx/
4 lines

Diff 404215

openmp/libomptarget/deviceRTLs/nvptx/CMakeLists.txt

##===----------------------------------------------------------------------===## ##===----------------------------------------------------------------------===##
# #
# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. # Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
# See https://llvm.org/LICENSE.txt for license information. # See https://llvm.org/LICENSE.txt for license information.
# SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception # SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
# #
##===----------------------------------------------------------------------===## ##===----------------------------------------------------------------------===##
# #
# Build the NVPTX (CUDA) Device RTL if the CUDA tools are available # Build the NVPTX (CUDA) Device RTL if the CUDA tools are available
# #
##===----------------------------------------------------------------------===## ##===----------------------------------------------------------------------===##
# By default we will build NVPTX deviceRTL on a CUDA free system # By default we will build NVPTX deviceRTL on a CUDA free system
set(LIBOMPTARGET_BUILD_NVPTX_BCLIB FALSE CACHE BOOL set(LIBOMPTARGET_BUILD_NVPTX_BCLIB FALSE CACHE BOOL
"Whether build NVPTX deviceRTL on CUDA free system.") "Whether build NVPTX deviceRTL on CUDA free system.")
if (NOT (LIBOMPTARGET_DEP_CUDA_FOUND OR LIBOMPTARGET_BUILD_NVPTX_BCLIB)) if (NOT LIBOMPTARGET_BUILD_NVPTX_BCLIB)
libomptarget_say("Not building NVPTX deviceRTL by default on CUDA free system.") libomptarget_say("Not building NVPTX deviceRTL: Disabled by LIBOMPTARGET_BUILD_NVPTX_BCLIB")
return() return()
endif() endif()
if (NOT LIBOMPTARGET_LLVM_INCLUDE_DIRS) if (NOT LIBOMPTARGET_LLVM_INCLUDE_DIRS)
libomptarget_say("Not building NVPTX device RTL: Missing definition for LIBOMPTARGET_LLVM_INCLUDE_DIRS") libomptarget_say("Not building NVPTX device RTL: Missing definition for LIBOMPTARGET_LLVM_INCLUDE_DIRS")
return() return()
endif() endif()
▲ Show 20 Lines • Show All 231 Lines • Show Last 20 Lines