This is an archive of the discontinued LLVM Phabricator instance.

Add cmake to source release tarballs
ClosedPublic

Authored by kwk on Jan 28 2022, 8:31 AM.

Details

Summary

I've split the git archive generation into three steps:

  1. generate pure tarball
  2. append top-level cmake directory to all tarballs
  3. compress the archive

This was inspired by D118252 and can be considered an alternative
approach for all projects to have access to the shared cmake
directory when building in standalone mode.

When generating source tarballs on my local laptop it takes 9 minutes and 45 seconds WITH this patch applied. When this patch is not applied, it takes 9minutes and 38 seconds. That means, this patch introduces a slowdown of 7 seconds, which seems fair.

Diff Detail

Event Timeline

kwk requested review of this revision.Jan 28 2022, 8:31 AM
kwk created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2022, 8:31 AM
kwk edited the summary of this revision. (Show Details)Jan 28 2022, 9:09 AM

I like that approach. Have you tested that putting the shared cmakefile in that location is enough for individual project to honor them?

kwk added a comment.EditedFeb 1 2022, 9:50 AM

I like that approach. Have you tested that putting the shared cmakefile in that location is enough for individual project to honor them?

Ups, no I could try that but so far I haven't. For current Fedora snapshots of LLVM I package the directory under a sub-package of llvm: llvm-cmake-devel. It installs the cmake files into a location that others can find: /usr/lib64/cmake/llvm.

The compiler-rt package is one consumer of this package and it seems to work.

tstellar accepted this revision.Feb 2 2022, 9:59 AM

I think this is fine.

This revision is now accepted and ready to land.Feb 2 2022, 9:59 AM
kwk updated this revision to Diff 407818.Feb 11 2022, 2:54 AM

Rebased. No changes.

This revision was landed with ongoing or failed builds.Feb 11 2022, 2:54 AM
This revision was automatically updated to reflect the committed changes.