This is an archive of the discontinued LLVM Phabricator instance.

[X86][avx512fp16] Promote fp16 to fp32 for frem.
ClosedPublic

Authored by LuoYuanke on Jan 28 2022, 6:55 AM.

Details

Diff Detail

Event Timeline

LuoYuanke created this revision.Jan 28 2022, 6:55 AM
LuoYuanke requested review of this revision.Jan 28 2022, 6:55 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 28 2022, 6:55 AM
RKSimon added inline comments.Jan 28 2022, 7:14 AM
llvm/test/CodeGen/X86/avx512fp16-frem.ll
5

use nounwind to get rid of the cfi noise?

LuoYuanke updated this revision to Diff 404207.Jan 28 2022, 6:27 PM

Address Simon's comments.

LuoYuanke updated this revision to Diff 404208.Jan 28 2022, 6:30 PM

Reformat code.

pengfei added inline comments.Jan 28 2022, 6:39 PM
llvm/lib/Target/X86/X86ISelLowering.cpp
807–810

Can we add MVT::v8f16, MVT::v16f16, MVT::v32f16 here instead? I think it's fine not adding tests to others at the present.

2014

STRICT nodes are set Expand by default. We don't need to set again.
The same below.

LuoYuanke updated this revision to Diff 404213.Jan 28 2022, 7:04 PM

Address Phoebe's comments.

pengfei accepted this revision.Jan 28 2022, 7:11 PM

LGTM. Thanks Yuanke!

This revision is now accepted and ready to land.Jan 28 2022, 7:11 PM
This revision was landed with ongoing or failed builds.Jan 28 2022, 7:41 PM
This revision was automatically updated to reflect the committed changes.