This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Don't look through pointer types in canTailPredicateLoop()
ClosedPublic

Authored by nikic on Jan 27 2022, 5:28 AM.

Details

Summary

Inspecting the pointer element type here is incompatible with opaque pointers, and doesn't seem necessary to me. I think the intention here might have been to check the type of load/store pointer arguments, but I believe those should get checked through their return type or value operand anyway. I don't get any test failures if I simply drop this.

Diff Detail

Event Timeline

nikic created this revision.Jan 27 2022, 5:28 AM
nikic requested review of this revision.Jan 27 2022, 5:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 27 2022, 5:28 AM
dmgreen accepted this revision.Jan 27 2022, 6:43 AM

I agree. LGTM

This revision is now accepted and ready to land.Jan 27 2022, 6:43 AM
This revision was landed with ongoing or failed builds.Jan 28 2022, 12:34 AM
This revision was automatically updated to reflect the committed changes.