This is an archive of the discontinued LLVM Phabricator instance.

[Matrix] Use ArrayType for allocas instead of VectorType.
ClosedPublic

Authored by fhahn on Jan 26 2022, 4:18 AM.

Details

Summary

When creating an alloca to copy a matrix due to memory conflicts, those
allocas used to use VectorTypes, which forced them to have huge
alignments for large vectors.

This patch updates LowerMatrixIntrinsics to use a corresponding array
type, like Clang already does, to get more manageable alignments.

Diff Detail

Event Timeline

fhahn created this revision.Jan 26 2022, 4:18 AM
fhahn updated this revision to Diff 403218.Jan 26 2022, 4:32 AM

Update to remove accidentially set 'Draft' status

fhahn published this revision for review.Jan 26 2022, 4:33 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 26 2022, 4:33 AM
anemet accepted this revision.Jan 27 2022, 9:05 AM

LGTM

This revision is now accepted and ready to land.Jan 27 2022, 9:05 AM
This revision was landed with ongoing or failed builds.Jan 28 2022, 2:48 AM
This revision was automatically updated to reflect the committed changes.