This is an archive of the discontinued LLVM Phabricator instance.

[PowerPC] Update ppc-prevent-mma-types.ll with custom opt pipeline
Needs ReviewPublic

Authored by amyk on Jan 25 2022, 6:45 AM.

Details

Reviewers
fhahn
Summary

The ppc-prevent-mma-types.ll test that was committed in D113900 had an issue
where wide vectors were being produced during PGO, and the SLP vectorizer appeared
to be an important pass to reproduce the issue seen in the original revision. However,
the original test had the -pgo-kind=pgo-instr-gen-pipeline, which does not explicitly
communicate that the SLP vectorizer affected to test case to produce the behaviour
that was seen.

This patch updates the opt pass pipeline to a minimal set of passes needed to reproduce the issue.

Diff Detail

Event Timeline

amyk created this revision.Jan 25 2022, 6:45 AM
amyk added inline comments.Jan 25 2022, 6:48 AM
llvm/test/Transforms/PGOProfile/ppc-prevent-mma-types.ll
2

@fhahn I was wondering on if you had any opinions on whether or not this is more acceptable as opposed to using -pgo-kind=pgo-instr-gen-pipeline.
I still require PGO related options such as pgo-instr-gen and instrprof, but does this count towards using the full PGO pipeline, since I'm just using those passes?