Page MenuHomePhabricator

[AVR][NFC] Improve CodeGen tests
AbandonedPublic

Authored by benshi001 on Jan 25 2022, 2:16 AM.

Details

Summary

Add '-verify-machineinstrs' to all CodeGen tests.

Diff Detail

Event Timeline

benshi001 created this revision.Jan 25 2022, 2:16 AM
benshi001 requested review of this revision.Jan 25 2022, 2:16 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 25 2022, 2:16 AM

Most AVR CodeGen tests lack -verify-machineinstrs options, so there are potential failures even make check-all passes.

So I add -verify-machineinstrs to all AVR CodeGen tests.

I don't think we should clutter up tests. -DLLVM_ENABLE_EXPENSIVE_CHECKS=on implies -verify-machineinstrs. There may be a proposal to enable -verify-machineinstrs automatically.

The problem may be to ensure isMachineVerifierClean returning false for AVR is correct.

MaskRay requested changes to this revision.Jan 25 2022, 1:06 PM
This revision now requires changes to proceed.Jan 25 2022, 1:06 PM

I don't think we should clutter up tests. -DLLVM_ENABLE_EXPENSIVE_CHECKS=on implies -verify-machineinstrs. There may be a proposal to enable -verify-machineinstrs automatically.

The problem may be to ensure isMachineVerifierClean returning false for AVR is correct.

Thanks. The AVRTargetMachine does not inherit the virtual base isMachineVerifierClean and always get true with -DLLVM_ENABLE_EXPENSIVE_CHECKS=on.

benshi001 abandoned this revision.Jan 25 2022, 7:10 PM
MatzeB added a comment.EditedJan 25 2022, 7:11 PM

See also https://llvm.org/PR32146 where we keep track which targets are not "clean" yet.

There apparently was https://reviews.llvm.org/D107853 though. Maybe people didn't actually test with an expensive checks enabled build (or with llvm-lit -Dllc="llc -verify-machineinstr")