Add '-verify-machineinstrs' to all CodeGen tests.
Details
Diff Detail
Event Timeline
Most AVR CodeGen tests lack -verify-machineinstrs options, so there are potential failures even make check-all passes.
So I add -verify-machineinstrs to all AVR CodeGen tests.
I don't think we should clutter up tests. -DLLVM_ENABLE_EXPENSIVE_CHECKS=on implies -verify-machineinstrs. There may be a proposal to enable -verify-machineinstrs automatically.
The problem may be to ensure isMachineVerifierClean returning false for AVR is correct.
Thanks. The AVRTargetMachine does not inherit the virtual base isMachineVerifierClean and always get true with -DLLVM_ENABLE_EXPENSIVE_CHECKS=on.
See also https://llvm.org/PR32146 where we keep track which targets are not "clean" yet.
There apparently was https://reviews.llvm.org/D107853 though. Maybe people didn't actually test with an expensive checks enabled build (or with llvm-lit -Dllc="llc -verify-machineinstr")