This is an archive of the discontinued LLVM Phabricator instance.

[flang] Accept INDEX(..., BACK=array)
ClosedPublic

Authored by klausler on Jan 19 2022, 10:15 AM.

Details

Summary

The intrinsic table entry for INDEX mistakenly required
the optional BACK= argument to be scalar, but it's an
elemental intrinsic that can accept a conforming array.

Diff Detail

Event Timeline

klausler created this revision.Jan 19 2022, 10:15 AM
klausler requested review of this revision.Jan 19 2022, 10:15 AM
PeteSteinfeld requested changes to this revision.Jan 19 2022, 11:04 AM

The change to intrinsics.cpp looks good, but Phabricator thinks that folding05.f90 is a binary file, and I can't create a patched repository with it. Is it possible that there's a weird line ending or and encoding problem in it?

This revision now requires changes to proceed.Jan 19 2022, 11:04 AM

The change to intrinsics.cpp looks good, but Phabricator thinks that folding05.f90 is a binary file, and I can't create a patched repository with it. Is it possible that there's a weird line ending or and encoding problem in it?

This comes up every time I add a test to that file. There are UTF-8 character strings in that test. Can you review based on inspection of the one-word change ("scalar" -> "elemental") in the code?

PeteSteinfeld accepted this revision.Jan 19 2022, 11:25 AM

Thanks for the information about encodings.

All builds, tests, and looks good.

This revision is now accepted and ready to land.Jan 19 2022, 11:25 AM
This revision was landed with ongoing or failed builds.Jan 19 2022, 5:54 PM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptJan 19 2022, 5:54 PM