When compiling with dwarf info, the mfix4300 flag introduced in https://reviews.llvm.org/D116238 can miss some occurrences of the vr4300 mulmul bug if a debug instruction happens to be between two muls.
This revision skips debug instructions in order to fix the mulmul bug detection.
Details
Details
- Reviewers
atanasyan - Commits
- rGee198df2e14c: [mips] Improve vr4300 mulmul bugfix pass
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
By the way, last time I made a contribution, the address that was used for the commit was the address I entered on phabricator to receive notifications.
Since I'm new to LLVM/phabricator I'm not sure where to ask if there's a way to make it so my github address (28494085+Random06457@users.noreply.github.com) is used instead for commits.
I can't get this address verified on phabricator since it's a noreply address.
Comment Actions
LGTM with a small fix. I will commit the changes shortly.
llvm/lib/Target/Mips/MipsMulMulBugPass.cpp | ||
---|---|---|
120 | You can use the next_nodbg function to write this line as NextMII = next_nodbg(MII, E);. |
You can use the next_nodbg function to write this line as NextMII = next_nodbg(MII, E);.