This is an archive of the discontinued LLVM Phabricator instance.

[mips] fix -mfix4300
ClosedPublic

Authored by Random06457 on Jan 18 2022, 2:56 PM.

Details

Summary

When compiling with dwarf info, the mfix4300 flag introduced in https://reviews.llvm.org/D116238 can miss some occurrences of the vr4300 mulmul bug if a debug instruction happens to be between two muls.
This revision skips debug instructions in order to fix the mulmul bug detection.

Fixes https://github.com/llvm/llvm-project/issues/53094

Diff Detail

Event Timeline

Random06457 created this revision.Jan 18 2022, 2:56 PM
Random06457 requested review of this revision.Jan 18 2022, 2:56 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 18 2022, 2:56 PM

By the way, last time I made a contribution, the address that was used for the commit was the address I entered on phabricator to receive notifications.
Since I'm new to LLVM/phabricator I'm not sure where to ask if there's a way to make it so my github address (28494085+Random06457@users.noreply.github.com) is used instead for commits.
I can't get this address verified on phabricator since it's a noreply address.

atanasyan accepted this revision.Jan 20 2022, 9:03 AM

LGTM with a small fix. I will commit the changes shortly.

llvm/lib/Target/Mips/MipsMulMulBugPass.cpp
120

You can use the next_nodbg function to write this line as NextMII = next_nodbg(MII, E);.

This revision is now accepted and ready to land.Jan 20 2022, 9:03 AM
This revision was landed with ongoing or failed builds.Jan 20 2022, 9:10 AM
This revision was automatically updated to reflect the committed changes.