[mlir][linalg] Insert a cast for identity linalg.generics when the types don't match
ClosedPublic
Actions

Authored by bkramer on Jan 17 2022, 8:40 AM.

Details

Reviewers

nicolasvasilache
mravishankar

Commits

rGf100bedb0362: [mlir][linalg] Insert a cast for identity linalg.generics when the types don't…

Summary

This can happen when the result has different dynamic dimensions than
the input.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

bkramer created this revision.Jan 17 2022, 8:40 AM

Herald added subscribers: sdasgup3, wenzhicui, wrengr and 20 others. · View Herald TranscriptJan 17 2022, 8:40 AM

bkramer requested review of this revision.Jan 17 2022, 8:40 AM

Herald added a project: Restricted Project. · View Herald TranscriptJan 17 2022, 8:40 AM

Herald added subscribers: limo1996, stephenneuendorffer. · View Herald Transcript

Harbormaster completed remote builds in B143815: Diff 400565.Jan 17 2022, 8:58 AM

Thanks! This is another use case for better static dims propagation.

This revision is now accepted and ready to land.Jan 18 2022, 1:42 PM

Closed by commit rGf100bedb0362: [mlir][linalg] Insert a cast for identity linalg.generics when the types don't… (authored by bkramer). · Explain WhyJan 18 2022, 2:44 PM

This revision was automatically updated to reflect the committed changes.

bkramer added a commit: rGf100bedb0362: [mlir][linalg] Insert a cast for identity linalg.generics when the types don't….

Revision Contents
Changeset List

Path

Size

mlir/

lib/

Dialect/

Linalg/

IR/

LinalgOps.cpp

13 lines

test/

Dialect/

Linalg/

canonicalize.mlir

21 lines

Diff 400999

View Options

mlir/lib/Dialect/Linalg/IR/LinalgOps.cpp