Page MenuHomePhabricator

Allows deferred location attribute in `parseOptionalLocationSpecifier`
ClosedPublic

Authored by mehdi_amini on Jan 15 2022, 6:32 PM.

Details

Summary

Before this patch, deferred location in operation like test.pretty_printed_region would
break the parser, and so the IR round-trip.

Depends On D117088

Diff Detail

Event Timeline

mehdi_amini created this revision.Jan 15 2022, 6:32 PM
mehdi_amini requested review of this revision.Jan 15 2022, 6:32 PM
rriddle added inline comments.Jan 18 2022, 10:21 AM
mlir/lib/Parser/Parser.cpp
344–347
1759–1760
1808

Is this ever false now?

mehdi_amini marked 3 inline comments as done.

Rebase

mehdi_amini added inline comments.Jan 18 2022, 12:42 PM
mlir/lib/Parser/Parser.cpp
1808

I don't think so! This is also in the parent revision, I fixed it there

This revision is now accepted and ready to land.Jan 18 2022, 12:45 PM
This revision was landed with ongoing or failed builds.Jan 18 2022, 2:00 PM
This revision was automatically updated to reflect the committed changes.