Page MenuHomePhabricator

[CMake] Fixes /INCREMENTAL detection when considering adding /Brepro
ClosedPublic

Authored by ychen on Jan 14 2022, 6:55 PM.

Details

Summary

/INCREMENTAL is the linker default (lld-link and MSVC link). Specifying
"/INCREMENTAL:NO" is the only way to disable it. So checking for the
negative flag instead and check exe/module/shared link flags
independently.

Diff Detail

Event Timeline

ychen created this revision.Jan 14 2022, 6:55 PM
ychen requested review of this revision.Jan 14 2022, 6:55 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 14 2022, 6:55 PM
rnk accepted this revision.Jan 24 2022, 10:45 AM

lgtm

This revision is now accepted and ready to land.Jan 24 2022, 10:45 AM
This revision was landed with ongoing or failed builds.Jan 24 2022, 2:27 PM
This revision was automatically updated to reflect the committed changes.