This is an archive of the discontinued LLVM Phabricator instance.

[msan] Reset shadow of byval before call
ClosedPublic

Authored by vitalybuka on Jan 13 2022, 11:57 PM.

Details

Summary

If function is not sanitized we must reset shadow, not copy.

Depends on D117285

Diff Detail

Event Timeline

vitalybuka created this revision.Jan 13 2022, 11:57 PM
vitalybuka requested review of this revision.Jan 13 2022, 11:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2022, 11:57 PM

Is this necessary if we zero byval pointee shadow in the other patch?

Is this necessary if we zero byval pointee shadow in the other patch?

without the patch:

  1. test line 82 with byval -> reset and then copy shadow
  2. test line 82 without byval -> copy shadow

with the patch:

  1. test line 82 with byval -> reset shadow
  2. test line 82 without byval -> reset shadow
eugenis accepted this revision.Jan 14 2022, 2:27 PM

LGTM

This revision is now accepted and ready to land.Jan 14 2022, 2:27 PM
kda accepted this revision.Jan 14 2022, 5:50 PM

LGTM
and clean up formatting.

This revision was landed with ongoing or failed builds.Jan 14 2022, 10:35 PM
This revision was automatically updated to reflect the committed changes.