Bug 24332 - Fix the build of lldb under GNU/Linux when using autotools

[brucem]

I don't have the authority to approve something to be committed afaik, but hopefully my comments here are useful.

source/Plugins/Makefile

46

I'm not an expert in the autotools build system, but it seems likely that the ScriptInterpreters could be added to the global list of them rather than the per-OS ones. (This differs from what I wrote in the bug probably.)

It might be worth checking with Keno Fischer as well as he likes to have a build that doesn't use Python and he might have some feedback on this.

52

As above.

[zturner]

Looks good to me, sorry for breaking this!

[sylvestre.ledru]

Zachary, do you agree with Bruce? (that the change should be for every platform, not Darwin/Linux specific)?
I did the change locally but didn't push yet.

[zturner]

Probably it should be at least for FreeBSD, but I don't know that anyone else uses the autoconf build, and my understanding is that it's going away kind of soon anyway.

[sylvestre.ledru]

Update with the support of all archs (in case)

lib/Makefile

USEDLIBS = lldbAPI.a \
   LLVMMCDisassembler.a \
   LLVMProfileData.a \
   lldbPluginPlatformMacOSX.a \
   lldbPluginPlatformLinux.a \
   lldbPluginPlatformWindows.a \
   lldbPluginPlatformFreeBSD.a \
   lldbPluginPlatformPOSIX.a \
   lldbPluginPlatformKalimba.a \
-  lldbPluginPlatformAndroid.a
+  lldbPluginPlatformAndroid.a \
+  lldbPluginScriptInterpreterNone.a \
+  lldbPluginScriptInterpreterPython.a
 
 # Because GCC requires RTTI enabled for lldbCore (see source/Core/Makefile) it is
 # necessary to also link the clang rewriter libraries so vtable references can
 # be resolved correctly, if we are building with GCC.
 ifeq (g++,$(shell basename $(CXX) | cut -c 1-4))
   USEDLIBS += clangRewrite.a \
               clangRewriteFrontend.a
 endif

source/Plugins/Makefile

PARALLEL_DIRS := ABI/MacOSX-arm ABI/MacOSX-arm64 ABI/MacOSX-i386 ABI/SysV-i386 ABI/SysV-x86_64 \
   DynamicLoader/POSIX-DYLD \
   DynamicLoader/Hexagon-DYLD \
   DynamicLoader/MacOSX-DYLD \
   DynamicLoader/Windows-DYLD \
   OperatingSystem/Python \
   SystemRuntime/MacOSX \
   SymbolVendor/ELF \
   MemoryHistory/asan \
-  InstrumentationRuntime/AddressSanitizer
+  InstrumentationRuntime/AddressSanitizer \
+  ScriptInterpreter/Python ScriptInterpreter/None
 
 ifeq ($(HOST_OS),Darwin)
 PARALLEL_DIRS += Process/MacOSX-Kernel
 PARALLEL_DIRS += DynamicLoader/Darwin-Kernel
 PARALLEL_DIRS += SymbolVendor/MacOSX
 #PARALLEL_DIRS += Process/MacOSX-User
 PARALLEL_DIRS += Process/mach-core
 PARALLEL_DIRS += Process/elf-core
 PARALLEL_DIRS += JITLoader/GDB
 endif
 
 ifeq ($(HOST_OS),Linux)
 PARALLEL_DIRS += Process/Linux Process/POSIX
 PARALLEL_DIRS += Process/elf-core
 PARALLEL_DIRS += JITLoader/GDB
 endif
 
 ifeq ($(HOST_OS),MingW)
 PARALLEL_DIRS += Process/elf-core
 PARALLEL_DIRS += JITLoader/GDB
 endif
 
 ifneq (,$(filter $(HOST_OS), FreeBSD GNU/kFreeBSD))
 PARALLEL_DIRS += Process/FreeBSD Process/POSIX
 PARALLEL_DIRS += Process/elf-core
 PARALLEL_DIRS += JITLoader/GDB
 endif
 
 include $(LLDB_LEVEL)/Makefile

source/Plugins/ScriptInterpreter/None/Makefile

+##===- source/Plugins/ScriptInterpreter/None/Makefile ------------*- Makefile -*-===##
+# 
+#                     The LLVM Compiler Infrastructure
+#
+# This file is distributed under the University of Illinois Open Source
+# License. See LICENSE.TXT for details.
+# 
+##===----------------------------------------------------------------------===##
+
+LLDB_LEVEL := ../../../..
+LIBRARYNAME := lldbPluginScriptInterpreterNone
+BUILD_ARCHIVE = 1
+
+include $(LLDB_LEVEL)/Makefile

source/Plugins/ScriptInterpreter/Python/Makefile

+##===- source/Plugins/ScriptInterpreter/Python/Makefile ------------*- Makefile -*-===##
+# 
+#                     The LLVM Compiler Infrastructure
+#
+# This file is distributed under the University of Illinois Open Source
+# License. See LICENSE.TXT for details.
+# 
+##===----------------------------------------------------------------------===##
+
+LLDB_LEVEL := ../../../..
+LIBRARYNAME := lldbPluginScriptInterpreterPython
+BUILD_ARCHIVE = 1
+
+include $(LLDB_LEVEL)/Makefile