This is an archive of the discontinued LLVM Phabricator instance.

Differential D117153

[flang] Downgrade benign error message to a warning
ClosedPublic

Authored by klausler on Jan 12 2022, 2:08 PM.

Details

Reviewers
PeteSteinfeld
sscalpone
Commits
rG0f500d3dae70: [flang] Downgrade benign error message to a warning
Summary

It's not conforming to specify the SAVE attribute more than
once for a variable, but it also doesn't hurt anything and
isn't fatal in other Fortran compilers. Downgrade the
message to a warning for better portability.

Diff Detail

Event Timeline

klausler created this revision.Jan 12 2022, 2:08 PM
Herald added a reviewer: sscalpone. · View Herald TranscriptJan 12 2022, 2:08 PM
Herald added a subscriber: jdoerfert. · View Herald Transcript
klausler requested review of this revision.Jan 12 2022, 2:08 PM
Harbormaster completed remote builds in B143009: Diff 399453.Jan 12 2022, 2:28 PM
PeteSteinfeld accepted this revision.Jan 13 2022, 7:03 AM

All builds, tests, and looks good.

This revision is now accepted and ready to land.Jan 13 2022, 7:03 AM
Closed by commit rG0f500d3dae70: [flang] Downgrade benign error message to a warning (authored by klausler). · Explain WhyJan 13 2022, 4:27 PM
This revision was automatically updated to reflect the committed changes.
klausler added a commit: rG0f500d3dae70: [flang] Downgrade benign error message to a warning.
Herald added a project: Restricted Project. · View Herald TranscriptJan 13 2022, 4:27 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript

Revision Contents

PathSize
flang/
docs/
2 lines
lib/
Semantics/
2 lines
test/
Semantics/
13 lines
11 lines

Diff 399453

flang/docs/Extensions.md

Context not available.
exactly one is unlimited polymorphic). exactly one is unlimited polymorphic).
* External unit 0 is predefined and connected to the standard error output, * External unit 0 is predefined and connected to the standard error output,
and defined as `ERROR_UNIT` in the intrinsic `ISO_FORTRAN_ENV` module. and defined as `ERROR_UNIT` in the intrinsic `ISO_FORTRAN_ENV` module.
* Multiple specifications of the SAVE attribute on the same object
are allowed, with a warning.
### Extensions supported when enabled by options ### Extensions supported when enabled by options
Context not available.

flang/lib/Semantics/resolve-names.cpp

Context not available.
std::set<SourceName> &set, const SourceName &name) { std::set<SourceName> &set, const SourceName &name) {
auto pair{set.insert(name)}; auto pair{set.insert(name)};
if (!pair.second) { if (!pair.second) {
Say2(name, "SAVE attribute was already specified on '%s'"_err_en_US, Say2(name, "SAVE attribute was already specified on '%s'"_en_US,
*pair.first, "Previous specification of SAVE attribute"_en_US); *pair.first, "Previous specification of SAVE attribute"_en_US);
} }
} }
Context not available.

flang/test/Semantics/resolve107.f90

  • This file was added.
! RUN: %flang_fc1 -fsyntax-only %s 2>&1 | FileCheck %s
! Check warning on multiple SAVE attribute specifications
subroutine saves
save x
save y
!CHECK: SAVE attribute was already specified on 'y'
integer, save :: y
integer, save :: z
!CHECK: SAVE attribute was already specified on 'x'
!CHECK: SAVE attribute was already specified on 'z'
save x,z
end

flang/test/Semantics/resolve45.f90

Context not available.
end block end block
end end
subroutine s6
save x
save y
!ERROR: SAVE attribute was already specified on 'y'
integer, save :: y
integer, save :: z
!ERROR: SAVE attribute was already specified on 'x'
!ERROR: SAVE attribute was already specified on 'z'
save x,z
end
subroutine s7 subroutine s7
!ERROR: 'x' appears as a COMMON block in a SAVE statement but not in a COMMON statement !ERROR: 'x' appears as a COMMON block in a SAVE statement but not in a COMMON statement
save /x/ save /x/
Context not available.