This is an archive of the discontinued LLVM Phabricator instance.

Differential D117138

[libc] move strdup out of requiring SCUDO
ClosedPublic

Authored by michaelrj on Jan 12 2022, 11:59 AM.

Details

Reviewers
sivachandra
lntue
abrachet
Commits
rG0b442db9f62e: [libc] move strdup out of requiring SCUDO
Summary

strdup needs either scudo enabled or fullbuild disabled, this properly
adds the second condition

Diff Detail

Event Timeline

michaelrj created this revision.Jan 12 2022, 11:59 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2022, 11:59 AM
Herald added subscribers: libc-commits, ecnelises, tschuett, cryptoad. · View Herald Transcript
michaelrj requested review of this revision.Jan 12 2022, 11:59 AM
Harbormaster completed remote builds in B142979: Diff 399411.Jan 12 2022, 12:04 PM
sivachandra accepted this revision.Jan 14 2022, 12:51 AM
This revision is now accepted and ready to land.Jan 14 2022, 12:51 AM
lntue accepted this revision.Jan 14 2022, 6:19 AM
Closed by commit rG0b442db9f62e: [libc] move strdup out of requiring SCUDO (authored by michaelrj). · Explain WhyJan 14 2022, 1:32 PM
This revision was automatically updated to reflect the committed changes.
michaelrj added a commit: rG0b442db9f62e: [libc] move strdup out of requiring SCUDO.

Revision Contents

PathSize
libc/
config/
linux/
x86_64/
4 lines

Diff 400134

libc/config/linux/x86_64/entrypoints.txt

Show First 20 Lines • Show All 236 Lines • ▼ Show 20 Lines
if(LLVM_LIBC_INCLUDE_SCUDO) if(LLVM_LIBC_INCLUDE_SCUDO)
list(APPEND TARGET_LIBC_ENTRYPOINTS list(APPEND TARGET_LIBC_ENTRYPOINTS
# stdlib.h external entrypoints # stdlib.h external entrypoints
libc.src.stdlib.malloc libc.src.stdlib.malloc
libc.src.stdlib.calloc libc.src.stdlib.calloc
libc.src.stdlib.realloc libc.src.stdlib.realloc
libc.src.stdlib.free libc.src.stdlib.free
)
endif()
if(LLVM_LIBC_INCLUDE_SCUDO OR NOT LLVM_LIBC_FULL_BUILD)
list(APPEND TARGET_LIBC_ENTRYPOINTS
# string.h entrypoints that depend on malloc # string.h entrypoints that depend on malloc
libc.src.string.strdup libc.src.string.strdup
libc.src.string.strndup libc.src.string.strndup
) )
endif() endif()
set(TARGET_LLVMLIBC_ENTRYPOINTS set(TARGET_LLVMLIBC_ENTRYPOINTS
${TARGET_LIBC_ENTRYPOINTS} ${TARGET_LIBC_ENTRYPOINTS}
${TARGET_LIBM_ENTRYPOINTS} ${TARGET_LIBM_ENTRYPOINTS}
) )