This is an archive of the discontinued LLVM Phabricator instance.

Differential D117102

[BOLT][TEST] Move exceptions-instrumentation.test to X86
ClosedPublic

Authored by yota9 on Jan 12 2022, 4:34 AM.

Details

Reviewers
maksfb
rafaelauler
Amir
Commits
rG2d97f0f2efde: [BOLT][TEST] Move exceptions-instrumentation.test to X86
Summary

The aarch64 instrumentation is currently unsupported so the test is failing.

Diff Detail

Unit TestsFailed

TimeTest
110 msx64 windows > LLVM.ExecutionEngine/JITLink/AArch64::MachO_arm64_ehframe.s
160 msx64 windows > LLVM.tools/llvm-readobj/XCOFF::symbols-invalid.test

Event Timeline

yota9 created this revision.Jan 12 2022, 4:34 AM
Herald added a subscriber: kristof.beyls. · View Herald TranscriptJan 12 2022, 4:34 AM
yota9 requested review of this revision.Jan 12 2022, 4:34 AM
Harbormaster completed remote builds in B142890: Diff 399288.Jan 12 2022, 5:36 AM
yota9 retitled this revision from BOLT: Move exception_split test under X86 Dir to BOLT: Move exceptions-instrumentation test under X86 Dir.Jan 12 2022, 5:43 AM
Amir accepted this revision.Jan 12 2022, 8:09 AM

Yes, it makes sense to move this test. Thanks for catching it.
BTW, if Huawei is willing to set up an AArch64 buildbot for BOLT testing, it would be a very welcome addition so we could catch these issues early.

This revision is now accepted and ready to land.Jan 12 2022, 8:09 AM
yota9 added a comment.Jan 12 2022, 8:13 AM

Thanks @Amir ! We will discuss the buildbot, thank you!
Offtopic: I've finally moved my self to aarch64 platform, so I will see such problems quite fast :))) But of course we need to setup the testing machine somehow anyway :)

Amir added a comment.Jan 12 2022, 9:16 AM
In D117102#3237624, @yota9 wrote:

Thanks @Amir ! We will discuss the buildbot, thank you!
Offtopic: I've finally moved my self to aarch64 platform, so I will see such problems quite fast :))) But of course we need to setup the testing machine somehow anyway :)

Sounds great!
Do you want me to commit this diff for you?

yota9 added a comment.Jan 12 2022, 9:19 AM

I would be thankful, since currently I don't have commit permissions. Thank you!

Amir retitled this revision from BOLT: Move exceptions-instrumentation test under X86 Dir to [BOLT][TEST] Move exceptions-instrumentation.test to X86.Jan 12 2022, 9:21 AM
Amir edited the summary of this revision. (Show Details)
This revision was landed with ongoing or failed builds.Jan 12 2022, 9:25 AM
Closed by commit rG2d97f0f2efde: [BOLT][TEST] Move exceptions-instrumentation.test to X86 (authored by Amir). · Explain Why
This revision was automatically updated to reflect the committed changes.
Amir added a commit: rG2d97f0f2efde: [BOLT][TEST] Move exceptions-instrumentation.test to X86.
Herald added a project: Restricted Project. · View Herald TranscriptJan 12 2022, 9:25 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Amir added a comment.Jan 12 2022, 1:58 PM

@yota9:
Hi Vladislav,

I've edited the commit title but apparently it has reset the commit author which I didn't check. Unfortunately we can't rewrite the history to restore it. I apologize for pushing it without the right attribution. Will double-check before pushing next time.

yota9 added a comment.Jan 12 2022, 4:52 PM

Hello @Amir ! Don't worry, it is ok :)

yota9 added a comment.Jan 12 2022, 4:56 PM

BTW @Amir I think I've already received the the commitment rights, will check it tomorrow :)

Amir added a comment.Jan 12 2022, 6:59 PM
In D117102#3239193, @yota9 wrote:

Hello @Amir ! Don't worry, it is ok :)

👍

In D117102#3239194, @yota9 wrote:

BTW @Amir I think I've already received the the commitment rights, will check it tomorrow :)

Nice, pretty fast!

Revision Contents

Diff 399288

bolt/test/runtime/Inputs/exceptions_split.cpp

  • This file was moved to bolt/test/runtime/X86/Inputs/exceptions_split.cpp.

bolt/test/runtime/X86/Inputs/exceptions_split.cpp

  • This file was moved from bolt/test/runtime/Inputs/exceptions_split.cpp.
The contents of this file were not changed.

bolt/test/runtime/X86/exceptions-instrumentation.test

  • This file was moved from bolt/test/runtime/exceptions-instrumentation.test.
The contents of this file were not changed.

bolt/test/runtime/exceptions-instrumentation.test

  • This file was moved to bolt/test/runtime/X86/exceptions-instrumentation.test.