[clang-tidy] Fix RenamerClangTidyChecks suggesting invalid macro identifiers

[logan-5]

Summary

This behavior was fixed for regular identifiers in 9f3edc323a88c1a179a0a5a9dc9a87a2964c0d48, but the same fix was not applied to macro fixits.

This addresses https://github.com/llvm/llvm-project/issues/52895.

[njames93]

LGTM, Thanks. Don't know how I missed this one last time round.

clang-tools-extra/clang-tidy/utils/RenamerClangTidyCheck.cpp

void RenamerClangTidyCheck::checkMacro(SourceManager &SourceMgr,
   if (!MaybeFailure)
     return;
   FailureInfo &Info = *MaybeFailure;
   StringRef Name = MacroNameTok.getIdentifierInfo()->getName();
   NamingCheckId ID(MI->getDefinitionLoc(), std::string(Name));
   NamingCheckFailure &Failure = NamingCheckFailures[ID];
   SourceRange Range(MacroNameTok.getLocation(), MacroNameTok.getEndLoc());
 
+  if (!isValidAsciiIdentifier(Info.Fixup))
+    Failure.FixStatus = ShouldFixStatus::FixInvalidIdentifier;
+
   Failure.Info = std::move(Info);
   addUsage(ID, Range);
 }
 
 void RenamerClangTidyCheck::expandMacro(const Token &MacroNameTok,
                                         const MacroInfo *MI) {
   StringRef Name = MacroNameTok.getIdentifierInfo()->getName();
   NamingCheckId ID(MI->getDefinitionLoc(), std::string(Name));

clang-tools-extra/test/clang-tidy/checkers/bugprone-reserved-identifier.cpp

 int _________;
 // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: declaration uses identifier '_________', which is a reserved identifier; cannot be fixed automatically [bugprone-reserved-identifier]
 // CHECK-FIXES: {{^}}int _________;{{$}}
 
 int _;
 // CHECK-MESSAGES: :[[@LINE-1]]:5: warning: declaration uses identifier '_', which is reserved in the global namespace; cannot be fixed automatically [bugprone-reserved-identifier]
 // CHECK-FIXES: {{^}}int _;{{$}}
 
+// https://github.com/llvm/llvm-project/issues/52895
+#define _5_kmph_rpm 459
+// CHECK-MESSAGES: :[[@LINE-1]]:9: warning: declaration uses identifier '_5_kmph_rpm', which is reserved in the global namespace; cannot be fixed automatically [bugprone-reserved-identifier]
+// CHECK-FIXES: {{^}}#define _5_kmph_rpm 459{{$}}
+
 // these should pass
 #define MACRO(m) int m = 0
 
 namespace Ns {
 class Object {
   int Member;
 };
 float Global;