This is an archive of the discontinued LLVM Phabricator instance.

[lld][macho] Fix test to sort symbol table before dumping
ClosedPublic

Authored by oontvoo on Jan 7 2022, 8:13 AM.

Details

Summary

Detail: The test previously expected a specific order of those symbols,
which is not guaranteed (could change simply due to hashing changes, etc).
So have it explicitly sort the symbols before checking the content.

PR/53026

Diff Detail

Event Timeline

oontvoo created this revision.Jan 7 2022, 8:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2022, 8:13 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
oontvoo requested review of this revision.Jan 7 2022, 8:13 AM
Herald added a project: Restricted Project. · View Herald TranscriptJan 7 2022, 8:13 AM
oontvoo updated this revision to Diff 398156.Jan 7 2022, 8:16 AM

fix values

int3 accepted this revision.Jan 7 2022, 2:07 PM
int3 added a subscriber: int3.

Thanks!

This revision is now accepted and ready to land.Jan 7 2022, 2:07 PM
MaskRay accepted this revision.Jan 7 2022, 3:32 PM
oontvoo updated this revision to Diff 421941.Apr 11 2022, 9:00 AM

rebase before submitting

Herald added a project: Restricted Project. · View Herald TranscriptApr 11 2022, 9:00 AM
Herald added a subscriber: StephenFan. · View Herald Transcript
This revision was landed with ongoing or failed builds.Apr 11 2022, 9:01 AM
This revision was automatically updated to reflect the committed changes.