This is an archive of the discontinued LLVM Phabricator instance.

AST: Make getEffectiveDeclContext() a member function of ItaniumMangleContextImpl. NFCI.

Authored by pcc on Jan 6 2022, 3:36 PM.



In an upcoming change we are going to need to access mangler state
from the getEffectiveDeclContext() function. Therefore, make it a
member function of ItaniumMangleContextImpl. Any callers that are
not currently members of ItaniumMangleContextImpl or CXXNameMangler
are made members of one or the other depending on where they are
called from.

Diff Detail

Event Timeline

pcc requested review of this revision.Jan 6 2022, 3:36 PM
pcc created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 6 2022, 3:36 PM
jrtc27 accepted this revision.Feb 17 2022, 10:51 AM

This makes sense to me but I don't know if you want someone with more authority in these parts to review it

This revision is now accepted and ready to land.Feb 17 2022, 10:51 AM
This revision was automatically updated to reflect the committed changes.