This is an archive of the discontinued LLVM Phabricator instance.

[clang-format] Fix SeparateDefinitionBlocks docs and ...
ClosedPublic

Authored by HazardyKnusperkeks on Jan 3 2022, 2:17 PM.

Diff Detail

Event Timeline

HazardyKnusperkeks requested review of this revision.Jan 3 2022, 2:17 PM
HazardyKnusperkeks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptJan 3 2022, 2:17 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Without the enum documentation I got

$ ./clang/docs/tools/dump_format_style.py
Traceback (most recent call last):
  File "/c/GIT/llvm-dev/./clang/docs/tools/dump_format_style.py", line 344, in <module>
    opts = OptionsReader(f).read_options()
  File "/c/GIT/llvm-dev/./clang/docs/tools/dump_format_style.py", line 280, in read_options
    raise Exception('Invalid format, expected comment, field or enum\n' + line)
Exception: Invalid format, expected comment, field or enum
SDS_Leave,
ksyx added a comment.Jan 3 2022, 2:23 PM

Thanks for the fix :)

clang/docs/ReleaseNotes.rst
300 ↗(On Diff #397138)

The change is documented here to group with added options?

Thanks for the fix :)

No Problem.

clang/docs/ReleaseNotes.rst
300 ↗(On Diff #397138)

My bad, have overlooked that.

HazardyKnusperkeks marked an inline comment as done.Jan 3 2022, 2:37 PM
ksyx accepted this revision.Jan 3 2022, 3:11 PM

Thanks for the fix!

This revision is now accepted and ready to land.Jan 3 2022, 3:11 PM
curdeius accepted this revision.Jan 3 2022, 10:42 PM

LGTM.

MyDeveloperDay accepted this revision.Jan 4 2022, 2:06 AM
This revision was landed with ongoing or failed builds.Jan 5 2022, 3:32 AM
This revision was automatically updated to reflect the committed changes.