This is an archive of the discontinued LLVM Phabricator instance.

Differential D116136

[lldb] Add missing UTF-8 char basic type entries
ClosedPublic

Authored by ljmf00 on Dec 21 2021, 5:44 PM.

Details

Reviewers
labath
Commits
rG6d5b86f851a1: [lldb] Add missing UTF-8 char basic type entries
Summary

D120690 introduced eBasicTypeChar8 but missed proper documentation order. This also introduces the missing bindings data on Swig, which should correspond with the documented information.

Diff Detail

Event Timeline

ljmf00 requested review of this revision.Dec 21 2021, 5:44 PM
ljmf00 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 21 2021, 5:44 PM
Herald added a subscriber: lldb-commits. · View Herald Transcript
Harbormaster completed remote builds in B140326: Diff 395779.Dec 21 2021, 5:47 PM
Herald added a subscriber: JDevlieghere. · View Herald TranscriptDec 21 2021, 5:47 PM
ljmf00 added a child revision: D116138: [lldb] Add UTF-8 Basic Type on Clang TypeSystem.Dec 21 2021, 6:14 PM
ljmf00 added inline comments.Dec 21 2021, 6:40 PM
lldb/include/lldb/lldb-enumerations.h
750

Does the order of the enum matter here? Since this is part of the public API it might break something externally.

labath added a subscriber: labath.Dec 22 2021, 3:35 AM

I guess you'll want to use this type for your language plugin, but it seems a bit weird to have a value with no uses. Should we maybe also make c++ char8_t map to this type?

lldb/include/lldb/lldb-enumerations.h
750

Yes, this should go the the end of the enum (though we're not very good at enforcing it, so I wouldn't be surprised if some of these values were added "in the middle").

ljmf00 added a comment.Dec 22 2021, 11:35 AM
In D116136#3206294, @labath wrote:

I guess you'll want to use this type for your language plugin, but it seems a bit weird to have a value with no uses. Should we maybe also make c++ char8_t map to this type?

Yes, that is right, but I'm doing it on the stacked patch D116138. Perhaps I should squash both? I just tried to separate the changes.

lldb/include/lldb/lldb-enumerations.h
750

Ok, I'm going to move to the end to avoid user breakage.

ljmf00 mentioned this in D120690: [PDB] Add char8_t type.Mar 6 2022, 2:19 PM
ljmf00 updated this revision to Diff 434543.Jun 6 2022, 11:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 11:23 AM
ljmf00 edited the summary of this revision. (Show Details)Jun 6 2022, 11:24 AM

@labath In the meantime, a lot of time passed and someone patched it in D120690, but the order on the documentation is wrong and the Python bindings need swig definitions. This patch introduces those, after rebasing with main.

Harbormaster completed remote builds in B168110: Diff 434543.Jun 6 2022, 11:26 AM
ljmf00 retitled this revision from [lldb] Add UTF-8 char basic type to [lldb] Add missing UTF-8 char basic type entries.Jun 6 2022, 2:54 PM
labath accepted this revision.Jun 13 2022, 8:25 AM
This revision is now accepted and ready to land.Jun 13 2022, 8:25 AM
Closed by commit rG6d5b86f851a1: [lldb] Add missing UTF-8 char basic type entries (authored by ljmf00). · Explain WhyJun 13 2022, 10:36 AM
This revision was automatically updated to reflect the committed changes.
ljmf00 added a commit: rG6d5b86f851a1: [lldb] Add missing UTF-8 char basic type entries.

Revision Contents

PathSize
lldb/
bindings/
python/
1 line
docs/
1 line
include/
lldb/
1 line

Diff 395779

lldb/bindings/python/python-extensions.swig

Show First 20 Lines • Show All 557 Lines • ▼ Show 20 Linesdef is_numeric_type(basic_type):
if basic_type == eBasicTypeInvalid: return (False,False) if basic_type == eBasicTypeInvalid: return (False,False)
if basic_type == eBasicTypeVoid: return (False,False) if basic_type == eBasicTypeVoid: return (False,False)
if basic_type == eBasicTypeChar: return (True,False) if basic_type == eBasicTypeChar: return (True,False)
if basic_type == eBasicTypeSignedChar: return (True,True) if basic_type == eBasicTypeSignedChar: return (True,True)
if basic_type == eBasicTypeUnsignedChar: return (True,False) if basic_type == eBasicTypeUnsignedChar: return (True,False)
if basic_type == eBasicTypeWChar: return (True,False) if basic_type == eBasicTypeWChar: return (True,False)
if basic_type == eBasicTypeSignedWChar: return (True,True) if basic_type == eBasicTypeSignedWChar: return (True,True)
if basic_type == eBasicTypeUnsignedWChar: return (True,False) if basic_type == eBasicTypeUnsignedWChar: return (True,False)
if basic_type == eBasicTypeChar8: return (True,False)
if basic_type == eBasicTypeChar16: return (True,False) if basic_type == eBasicTypeChar16: return (True,False)
if basic_type == eBasicTypeChar32: return (True,False) if basic_type == eBasicTypeChar32: return (True,False)
if basic_type == eBasicTypeShort: return (True,True) if basic_type == eBasicTypeShort: return (True,True)
if basic_type == eBasicTypeUnsignedShort: return (True,False) if basic_type == eBasicTypeUnsignedShort: return (True,False)
if basic_type == eBasicTypeInt: return (True,True) if basic_type == eBasicTypeInt: return (True,True)
if basic_type == eBasicTypeUnsignedInt: return (True,False) if basic_type == eBasicTypeUnsignedInt: return (True,False)
if basic_type == eBasicTypeLong: return (True,True) if basic_type == eBasicTypeLong: return (True,True)
if basic_type == eBasicTypeUnsignedLong: return (True,False) if basic_type == eBasicTypeUnsignedLong: return (True,False)
Show All 20 Lines

lldb/docs/python_api_enums.rst

Show First 20 Lines • Show All 1,011 Lines • ▼ Show 20 Lines
.. py:data:: eBasicTypeInvalid .. py:data:: eBasicTypeInvalid
.. py:data:: eBasicTypeVoid .. py:data:: eBasicTypeVoid
.. py:data:: eBasicTypeChar .. py:data:: eBasicTypeChar
.. py:data:: eBasicTypeSignedChar .. py:data:: eBasicTypeSignedChar
.. py:data:: eBasicTypeUnsignedChar .. py:data:: eBasicTypeUnsignedChar
.. py:data:: eBasicTypeWChar .. py:data:: eBasicTypeWChar
.. py:data:: eBasicTypeSignedWChar .. py:data:: eBasicTypeSignedWChar
.. py:data:: eBasicTypeUnsignedWChar .. py:data:: eBasicTypeUnsignedWChar
.. py:data:: eBasicTypeChar8
.. py:data:: eBasicTypeChar16 .. py:data:: eBasicTypeChar16
.. py:data:: eBasicTypeChar32 .. py:data:: eBasicTypeChar32
.. py:data:: eBasicTypeShort .. py:data:: eBasicTypeShort
.. py:data:: eBasicTypeUnsignedShort .. py:data:: eBasicTypeUnsignedShort
.. py:data:: eBasicTypeInt .. py:data:: eBasicTypeInt
.. py:data:: eBasicTypeUnsignedInt .. py:data:: eBasicTypeUnsignedInt
.. py:data:: eBasicTypeLong .. py:data:: eBasicTypeLong
.. py:data:: eBasicTypeUnsignedLong .. py:data:: eBasicTypeUnsignedLong
▲ Show 20 Lines • Show All 381 Lines • Show Last 20 Lines

lldb/include/lldb/lldb-enumerations.h

Show First 20 Lines • Show All 741 Lines • ▼ Show 20 Linesenum BasicType {
eBasicTypeInvalid = 0, eBasicTypeInvalid = 0,
eBasicTypeVoid = 1, eBasicTypeVoid = 1,
eBasicTypeChar, eBasicTypeChar,
eBasicTypeSignedChar, eBasicTypeSignedChar,
eBasicTypeUnsignedChar, eBasicTypeUnsignedChar,
eBasicTypeWChar, eBasicTypeWChar,
eBasicTypeSignedWChar, eBasicTypeSignedWChar,
eBasicTypeUnsignedWChar, eBasicTypeUnsignedWChar,
eBasicTypeChar8,
ljmf00AuthorUnsubmitted
Done
ReplyInline Actions

Does the order of the enum matter here? Since this is part of the public API it might break something externally.

ljmf00: Does the order of the enum matter here? Since this is part of the public API it might break…
labathUnsubmitted
Not Done
ReplyInline Actions

Yes, this should go the the end of the enum (though we're not very good at enforcing it, so I wouldn't be surprised if some of these values were added "in the middle").

labath: Yes, this should go the the end of the enum (though we're not very good at enforcing it, so I…
ljmf00AuthorUnsubmitted
Done
ReplyInline Actions

Ok, I'm going to move to the end to avoid user breakage.

ljmf00: Ok, I'm going to move to the end to avoid user breakage.
eBasicTypeChar16, eBasicTypeChar16,
eBasicTypeChar32, eBasicTypeChar32,
eBasicTypeShort, eBasicTypeShort,
eBasicTypeUnsignedShort, eBasicTypeUnsignedShort,
eBasicTypeInt, eBasicTypeInt,
eBasicTypeUnsignedInt, eBasicTypeUnsignedInt,
eBasicTypeLong, eBasicTypeLong,
eBasicTypeUnsignedLong, eBasicTypeUnsignedLong,
▲ Show 20 Lines • Show All 388 Lines • Show Last 20 Lines