This is an archive of the discontinued LLVM Phabricator instance.

[lldb] Add missing UTF-8 char basic type entries
ClosedPublic

Authored by ljmf00 on Dec 21 2021, 5:44 PM.

Details

Summary

D120690 introduced eBasicTypeChar8 but missed proper documentation order. This also introduces the missing bindings data on Swig, which should correspond with the documented information.

Diff Detail

Event Timeline

ljmf00 requested review of this revision.Dec 21 2021, 5:44 PM
ljmf00 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 21 2021, 5:44 PM
ljmf00 added inline comments.Dec 21 2021, 6:40 PM
lldb/include/lldb/lldb-enumerations.h
750

Does the order of the enum matter here? Since this is part of the public API it might break something externally.

labath added a subscriber: labath.Dec 22 2021, 3:35 AM

I guess you'll want to use this type for your language plugin, but it seems a bit weird to have a value with no uses. Should we maybe also make c++ char8_t map to this type?

lldb/include/lldb/lldb-enumerations.h
750

Yes, this should go the the end of the enum (though we're not very good at enforcing it, so I wouldn't be surprised if some of these values were added "in the middle").

I guess you'll want to use this type for your language plugin, but it seems a bit weird to have a value with no uses. Should we maybe also make c++ char8_t map to this type?

Yes, that is right, but I'm doing it on the stacked patch D116138. Perhaps I should squash both? I just tried to separate the changes.

lldb/include/lldb/lldb-enumerations.h
750

Ok, I'm going to move to the end to avoid user breakage.

ljmf00 updated this revision to Diff 434543.Jun 6 2022, 11:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptJun 6 2022, 11:23 AM
ljmf00 edited the summary of this revision. (Show Details)Jun 6 2022, 11:24 AM

@labath In the meantime, a lot of time passed and someone patched it in D120690, but the order on the documentation is wrong and the Python bindings need swig definitions. This patch introduces those, after rebasing with main.

ljmf00 retitled this revision from [lldb] Add UTF-8 char basic type to [lldb] Add missing UTF-8 char basic type entries.Jun 6 2022, 2:54 PM
labath accepted this revision.Jun 13 2022, 8:25 AM
This revision is now accepted and ready to land.Jun 13 2022, 8:25 AM
This revision was automatically updated to reflect the committed changes.