Page MenuHomePhabricator

[lldb] Add UTF-8 char basic type
Needs ReviewPublic

Authored by ljmf00 on Dec 21 2021, 5:44 PM.
This revision needs review, but there are no reviewers specified.

Details

Reviewers
None
Summary

A UTF-8 Basic type should be exposed the same way we have UTF-16 and UTF-32 basic types

Diff Detail

Event Timeline

ljmf00 requested review of this revision.Dec 21 2021, 5:44 PM
ljmf00 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptDec 21 2021, 5:44 PM
ljmf00 added inline comments.Dec 21 2021, 6:40 PM
lldb/include/lldb/lldb-enumerations.h
750

Does the order of the enum matter here? Since this is part of the public API it might break something externally.

labath added a subscriber: labath.Dec 22 2021, 3:35 AM

I guess you'll want to use this type for your language plugin, but it seems a bit weird to have a value with no uses. Should we maybe also make c++ char8_t map to this type?

lldb/include/lldb/lldb-enumerations.h
750

Yes, this should go the the end of the enum (though we're not very good at enforcing it, so I wouldn't be surprised if some of these values were added "in the middle").

I guess you'll want to use this type for your language plugin, but it seems a bit weird to have a value with no uses. Should we maybe also make c++ char8_t map to this type?

Yes, that is right, but I'm doing it on the stacked patch D116138. Perhaps I should squash both? I just tried to separate the changes.

lldb/include/lldb/lldb-enumerations.h
750

Ok, I'm going to move to the end to avoid user breakage.