[lldb] Add missing UTF-8 char basic type entries

[ljmf00]

Summary

D120690 introduced eBasicTypeChar8 but missed proper documentation order. This also introduces the missing bindings data on Swig, which should correspond with the documented information.

[ljmf00]

lldb/include/lldb/lldb-enumerations.h

750 ↗

(On Diff #395779)

Does the order of the enum matter here? Since this is part of the public API it might break something externally.

[labath]

I guess you'll want to use this type for your language plugin, but it seems a bit weird to have a value with no uses. Should we maybe also make c++ char8_t map to this type?

lldb/include/lldb/lldb-enumerations.h

750 ↗

(On Diff #395779)

Yes, this should go the the end of the enum (though we're not very good at enforcing it, so I wouldn't be surprised if some of these values were added "in the middle").

[ljmf00]

In D116136#3206294, @labath wrote:

I guess you'll want to use this type for your language plugin, but it seems a bit weird to have a value with no uses. Should we maybe also make c++ char8_t map to this type?

Yes, that is right, but I'm doing it on the stacked patch D116138. Perhaps I should squash both? I just tried to separate the changes.

lldb/include/lldb/lldb-enumerations.h

750 ↗

(On Diff #395779)

Ok, I'm going to move to the end to avoid user breakage.

[ljmf00]

@labath In the meantime, a lot of time passed and someone patched it in D120690, but the order on the documentation is wrong and the Python bindings need swig definitions. This patch introduces those, after rebasing with main.

lldb/bindings/python/python-extensions.swig

def is_numeric_type(basic_type):
     if basic_type == eBasicTypeChar: return (True,False)
     if basic_type == eBasicTypeSignedChar: return (True,True)
     if basic_type == eBasicTypeUnsignedChar: return (True,False)
     if basic_type == eBasicTypeWChar: return (True,False)
     if basic_type == eBasicTypeSignedWChar: return (True,True)
     if basic_type == eBasicTypeUnsignedWChar: return (True,False)
     if basic_type == eBasicTypeChar16: return (True,False)
     if basic_type == eBasicTypeChar32: return (True,False)
+    if basic_type == eBasicTypeChar8: return (True,False)
     if basic_type == eBasicTypeShort: return (True,True)
     if basic_type == eBasicTypeUnsignedShort: return (True,False)
     if basic_type == eBasicTypeInt: return (True,True)
     if basic_type == eBasicTypeUnsignedInt: return (True,False)
     if basic_type == eBasicTypeLong: return (True,True)
     if basic_type == eBasicTypeUnsignedLong: return (True,False)
     if basic_type == eBasicTypeLongLong: return (True,True)
     if basic_type == eBasicTypeUnsignedLongLong: return (True,False)

lldb/docs/python_api_enums.rst

 .. py:data:: eBasicTypeInvalid
 .. py:data:: eBasicTypeVoid
 .. py:data:: eBasicTypeChar
 .. py:data:: eBasicTypeSignedChar
 .. py:data:: eBasicTypeUnsignedChar
 .. py:data:: eBasicTypeWChar
 .. py:data:: eBasicTypeSignedWChar
 .. py:data:: eBasicTypeUnsignedWChar
-.. py:data:: eBasicTypeChar8
 .. py:data:: eBasicTypeChar16
 .. py:data:: eBasicTypeChar32
+.. py:data:: eBasicTypeChar8
 .. py:data:: eBasicTypeShort
 .. py:data:: eBasicTypeUnsignedShort
 .. py:data:: eBasicTypeInt
 .. py:data:: eBasicTypeUnsignedInt
 .. py:data:: eBasicTypeLong
 .. py:data:: eBasicTypeUnsignedLong
 .. py:data:: eBasicTypeLongLong
 .. py:data:: eBasicTypeUnsignedLongLong